Adding some missing policy elements from the templates. #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encrypted scratch was added the policy and open door templates were not updated properly, i.e. the SVN was not incremented and `scratch_mount` and `scratch_unmount` were not added to the open door template. I've added a test which will keep this from happening in the future. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
hgarvison
approved these changes
Nov 21, 2022
anmaxvl
approved these changes
Nov 21, 2022
|
@anmaxvl can this be merged now? |
helsaawy
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encrypted scratch was added the policy and open door templates were not updated properly, i.e. the SVN was not incremented and
scratch_mountandscratch_unmountwere not added to the open door template. I've added a test which will keep this from happening in the future.