Pass ipv6 address information to Linux GCS #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, HCN endpoint ipv6 settings are not passed into the Linux guest, so containers will not be assigned their ipv6 addresses. Update shim to forward that information into the guest, add updates the guest to assign both sets of addresses. Added tests for ipv6 functionality. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
|
Few comments, otherwise it looks good to me. |
anmaxvl
approved these changes
Oct 28, 2022
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Pass ipv6 address information to Linux GCS Currently, HCN endpoint ipv6 settings are not passed into the Linux guest, so containers will not be assigned their ipv6 addresses. Update shim to forward that information into the guest, add updates the guest to assign both sets of addresses. Added tests for ipv6 functionality. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> * PR: vestigial comment, logging Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, HCN endpoint IPv6 settings are not passed into the Linux guest, so containers will not be assigned the v6 addresses that the host endpoint has.
This PR updates the shim to forward IPv6 information to the guest, updates the guest to assign both v4 and v6 addresses, if they are present, and adds tests for ipv6 functionality.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com