Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint ./ext4 directory #1537

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Lint ./ext4 directory #1537

merged 1 commit into from
Oct 12, 2022

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Oct 6, 2022 •
edited
Loading

Add ext4 directory to paths linted for GOOS=linux

Fix linting issues in ext4/internal/compactext4/verify_linux_test.go:

  • replace deprecated syscall.StringBytePtr(path) with syscall.BytePtrFromString(path)
  • add t.Helper to helper functions

@helsaawy
lint ext4 folder for linux
69c2e47 
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy changed the title Lint ext4 for Linux Lint ./ext4 directory Oct 6, 2022
@helsaawy helsaawy marked this pull request as ready for review October 6, 2022 22:36
@helsaawy helsaawy requested a review from a team as a code owner October 6, 2022 22:36
ambarve
ambarve approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but looks good otherwise!

ext4/internal/compactext4/verify_linux_test.go Show resolved Hide resolved
@helsaawy helsaawy merged commit a72cbcd into microsoft:main Oct 12, 2022
@helsaawy helsaawy deleted the test-ext4 branch October 12, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarve ambarve ambarve approved these changes

Assignees

@ambarve ambarve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helsaawy @ambarve