Open Door fix for Rego policies #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…policies. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
anmaxvl
approved these changes
Sep 8, 2022
dcantah
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning OpenDoorSecurityPolicyEnforcer (when appropriate) for Rego policies. This change reverts an unintended behaviour change when calling
CreateSecurityPolicyEnforcerwith:enforcer = ""indicating to use the default (which, with theregobuild tag, will berego)base64EncodedPolicy= a JSON policy withAllowAll=Trueand no containersIn the past this would have produced an
OpenDoorSecurityPolicyEnforcerbut after the change to accept authored Rego policies, it would produce aRegoEnforcerwith an allow all policy (which allows all enforcement points). There are changes in the pipe which will make aRegoEnforcercreated in this way have the same properties asOpenDoorSecurityPolicyEnforcer, but for the time being this change reverts to the previous state.