-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golangci-lint issues #1480
Fix golangci-lint issues #1480
Conversation
030984c
to
7df155b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor doc comment formatting issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. did gofmt mangle the comments in a few places?
So obviously there's a ton of messed up comment formatting. Are you still investigating this? |
Yea.. I thought this was on draft if I'm being honest 😿Hamza's comments let me know this was not the case haha. I haven't looked at this since this morning, but I'm looking now. Need to find what gofmt doesn't like anymore |
2c634c1
to
c09675e
Compare
Gets rid of io/ioutil usage in favor of the os and io replacements. ioutil has been deprecated since 1.16. This additionally starts to use t.TestDir() in some tests instead which is a nice side effect. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
We had a stray use of syscall.Syscall that should be in winapi with the rest of our defs. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
We're reworking the hcs/errors package soon, but in the meantime don't lint the use of the deprecated err.Temporary. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
gofmt -s on go 1.19 Signed-off-by: Daniel Canter <dcanter@microsoft.com>
v3 golangci-lint action removed the skip-go-installation flag and now explicitly requires using the setup-go action to function. - Get rid of skip-go-installation - Swap to v3 of setup-go - Remove only-new-issues usage Signed-off-by: Daniel Canter <dcanter@microsoft.com>
c09675e
to
bf8bdb0
Compare
Squashed, will wait for CI to finish again |
Fix golangci-lint issues
With an upgrade to our linter comes a lot of new yelling at us. This does quite a bit:
t.TempDir()
which was a nice side effect.and not call
syscall.Syscall
directly.net.Error.Temporary
usage for now.net.Error
's temporary method is deprecated since 1.18 but we make sureHcsError
,ProcessError
andSystemError
all adhere tonet.Error
's interface which contains theTemporary
method. We're reworking the hcs errors package shortly and I'm not sure of the history or significance behind that choice. This seems sane for now.