Update hcs errors to gov1.13 style #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Jul 12, 2022
dcantah
reviewed
Jul 12, 2022
dcantah
reviewed
Jul 12, 2022
dcantah
reviewed
Jul 12, 2022
dcantah
approved these changes
Jul 12, 2022
|
@helsaawy There's a small conflict now, but this still needs another set of eyes 😐 |
Add `.Is(` and `.Unwrap(` to `internal\hcs\errors.go` to using them with `errors.Is(`, as well as `internal\gcs\bridge.go`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
he/errors-1.13
branch
from
595eb1a
to
c62aa0a
Compare
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
he/errors-1.13
branch
from
c62aa0a
to
98b4716
Compare
anmaxvl
approved these changes
Sep 15, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Update hcs errors to gov1.13 style Add `.Is(` and `.Unwrap(` to `internal\hcs\errors.go` to using them with `errors.Is(`, as well as `internal\gcs\bridge.go`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> * PR: logic bug, declaration style Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.Is(and.Unwrap(tointernal\hcs\errors.goandinternal\gcs\bridge.goto using them witherrors.Is(anderrors.As(Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com