Change bind filter API used #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to using BfSetupFilter instead of BfSetupFilterEx. The Ex variant is only useful if you want to pass a SID to perform the bind as a specific user. We don't use this functionality, and it didn't exist on some versions of Windows as well. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
helsaawy
approved these changes
Jun 8, 2022
katiewasnothere
approved these changes
Jun 8, 2022
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jul 11, 2022
Change to using BfSetupFilter instead of BfSetupFilterEx. The Ex variant is only useful if you want to pass a SID to perform the bind as a specific user. We don't use this functionality, and it didn't exist on some versions of Windows as well. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Change to using BfSetupFilter instead of BfSetupFilterEx. The Ex variant is only useful if you want to pass a SID to perform the bind as a specific user. We don't use this functionality, and it didn't exist on some versions of Windows as well. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to using BfSetupFilter instead of BfSetupFilterEx. The Ex variant is
only useful if you want to pass a SID to perform the bind as a specific
user. We don't use this functionality, and it didn't exist on some
versions of Windows as well.