-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lcow driver installation path #1383
Merged
katiewasnothere
merged 3 commits into
microsoft:main
from
katiewasnothere:remove_nvidia_boot_files
Sep 8, 2022
Merged
Update lcow driver installation path #1383
katiewasnothere
merged 3 commits into
microsoft:main
from
katiewasnothere:remove_nvidia_boot_files
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failin on verify-test-vendor |
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
April 28, 2022 23:51
ef7f046
to
9ffda36
Compare
anmaxvl
reviewed
May 6, 2022
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
2 times, most recently
from
June 28, 2022 23:40
0687641
to
22b8476
Compare
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
July 19, 2022 19:21
22b8476
to
1759791
Compare
Rebased and force pushed to rerun the CI |
helsaawy
reviewed
Jul 19, 2022
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
July 25, 2022 19:48
1759791
to
a56ebe3
Compare
anmaxvl
approved these changes
Aug 24, 2022
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
August 24, 2022 20:19
5595995
to
a54a07c
Compare
Rebased |
helsaawy
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge once CI is green
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
September 8, 2022 05:32
a54a07c
to
1fa403c
Compare
- update `install-drivers` tool to take in additional parameter for driver read/write path - update call to `install-drivers` to take in new param - update nvidia hook to use CreateRuntime instead of Prestart hook Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
remove_nvidia_boot_files
branch
from
September 8, 2022 06:44
1fa403c
to
e364ad4
Compare
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…boot_files Update lcow driver installation path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-drivers
tool to take in additional parameter fordriver read/write path
install-drivers
to take in new paramThis PR removes the need for a separate set of boot files for gpu code paths
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com