Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: fix typo #1310

Merged
merged 2 commits into from
Mar 1, 2022
Merged

all: fix typo #1310

merged 2 commits into from
Mar 1, 2022

Conversation

cuishuang
Copy link
Contributor

No description provided.

@cuishuang cuishuang requested a review from a team as a code owner March 1, 2022 01:58
@ghost
Copy link

ghost commented Mar 1, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@anmaxvl
Copy link
Contributor

anmaxvl commented Mar 1, 2022

thanks for the PR! can you do git commit --amend --signoff and repush?

@cuishuang
all: fix typo
2505b7b 
Signed-off-by: cuishuang <imcusg@gmail.com>
@cuishuang
Copy link
Contributor Author

thanks for the PR! can you do git commit --amend --signoff and repush?

Done

@anmaxvl
Copy link
Contributor

anmaxvl commented Mar 1, 2022

looks like you'll also need to do cd test && go mod vendor. I should've remembered it the first time 😄

@cuishuang
all: fix typos
2d6267f 
Signed-off-by: cuishuang <imcusg@gmail.com>
@cuishuang
Copy link
Contributor Author

implemented

@anmaxvl anmaxvl merged commit b8f7734 into microsoft:master Mar 1, 2022
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 28, 2024
@cuishuang
all: fix typo (microsoft#1310)
4a66c8c 
* all: fix typos

Signed-off-by: cuishuang <imcusg@gmail.com>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@cuishuang
all: fix typo (microsoft#1310)
10b9a33 
* all: fix typos

Signed-off-by: cuishuang <imcusg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuishuang @anmaxvl