-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conpty (pseudo console) package #1228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
conpty
branch
2 times, most recently
from
November 16, 2021 05:13
1738766
to
1d2b761
Compare
dcantah
commented
Nov 16, 2021
kevpar
reviewed
Nov 16, 2021
This change adds a conpty package that houses go friendly wrappers around the Pseudo Console API in Windows. This will be used to support tty scenarios for Host Process containers. There's not many tests I can add here as you need to hook this up to a running process, where that work is coming. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
The issue with x/sys/windows is being solved here https://go-review.googlesource.com/c/sys/+/371276/1/windows/exec_windows.go#153. This change adds a comment to state that we'll swap once the fix is in. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
katiewasnothere
approved these changes
Dec 13, 2021
anmaxvl
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise LGTM
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
* Add conpty (pseudo console) package This change adds a conpty package that houses go friendly wrappers around the Pseudo Console API in Windows. This will be used to support tty scenarios for Host Process containers. There's not many tests I can add here as you need to hook this up to a running process, where that work is coming. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit f8cbd0b) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
* Add conpty (pseudo console) package This change adds a conpty package that houses go friendly wrappers around the Pseudo Console API in Windows. This will be used to support tty scenarios for Host Process containers. There's not many tests I can add here as you need to hook this up to a running process, where that work is coming. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit f8cbd0b) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Add conpty (pseudo console) package This change adds a conpty package that houses go friendly wrappers around the Pseudo Console API in Windows. This will be used to support tty scenarios for Host Process containers. There's not many tests I can add here as you need to hook this up to a running process, where that work is coming. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a conpty package (and necessary bindings) that houses go friendly wrappers around
the Pseudo Console API in Windows. This will be used to support tty scenarios for Host Process containers.
There's not many tests I can add here as you need to hook this up to a running
process, where that work is coming soon. I've included a video of this working below using the
new process execution package I've been working on.
conpty.mp4
Code for the demo for a sneak peak at the API: