Skip to content

Commit

Permalink
Replace winapi GetQueuedCompletionStatus bind with x/sys/windows
Browse files Browse the repository at this point in the history
Previously we had our own definition for GetQueuedCompletionStatus as x/sys/windows
had an incorrect definition for it. This was remedied a bit ago in this change
golang/sys@683adc9
so we're alright to remove our own at this point.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
  • Loading branch information
dcantah committed Mar 3, 2022
1 parent 643ef46 commit a757565
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 35 deletions.
2 changes: 1 addition & 1 deletion internal/jobobject/iocp.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func pollIOCP(ctx context.Context, iocpHandle windows.Handle) {
)

for {
err := winapi.GetQueuedCompletionStatus(iocpHandle, &code, &key, (**windows.Overlapped)(unsafe.Pointer(&overlapped)), windows.INFINITE)
err := windows.GetQueuedCompletionStatus(iocpHandle, &code, &key, (**windows.Overlapped)(unsafe.Pointer(&overlapped)), windows.INFINITE)
if err != nil {
log.G(ctx).WithError(err).Error("failed to poll for job object message")
continue
Expand Down
3 changes: 0 additions & 3 deletions internal/winapi/iocp.go

This file was deleted.

2 changes: 1 addition & 1 deletion internal/winapi/winapi.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
// be thought of as an extension to golang.org/x/sys/windows.
package winapi

//go:generate go run ..\..\mksyscall_windows.go -output zsyscall_windows.go user.go console.go system.go net.go path.go thread.go iocp.go jobobject.go logon.go memory.go process.go processor.go devices.go filesystem.go errors.go
//go:generate go run ..\..\mksyscall_windows.go -output zsyscall_windows.go user.go console.go system.go net.go path.go thread.go jobobject.go logon.go memory.go process.go processor.go devices.go filesystem.go errors.go
13 changes: 0 additions & 13 deletions internal/winapi/zsyscall_windows.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a757565

Please sign in to comment.