Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GooglePlayReleaseBundle]Add changesNotSentForReview option #272

Merged

Conversation

vladislav-ryzhov
Copy link
Contributor

@vladislav-ryzhov vladislav-ryzhov commented May 13, 2021

Task name: Google Play release bundle

Description:
Added new input changesNotSentForReview. If the customer selects this option, changes will be sent to review.

I used the @ts-ignore comment because we don't have changesNotSentForReview option in edtits.commit method yet.
The changes for that option were added to the repo but the package with them has not released. info.
With @ts-ignore all goes well.

I think we couldn't reproduce this issue because we didn't have any rejections in Google Play Console and all our changes were send automatically. The customer had ones and it probably affected to process. Customer comment.
More info.

More info:
About changesNotSentForReview parameter
About this error:
Here is an example of how a similar problem was solved:
link#1
link#2
About how rejection can affect to review process you can find here

Documentation changes required: https://github.com/microsoft/google-play-vsts-extension/tree/users/VladislavRyzhov/updateReadMe

Added unit tests: N

Attached related issue: #270

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@vladislav-ryzhov vladislav-ryzhov requested a review from a team May 14, 2021 07:23
@vladislav-ryzhov vladislav-ryzhov requested a review from a team May 17, 2021 07:45
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please take a look at comments.

@anatolybolshakov anatolybolshakov requested a review from a team May 17, 2021 17:08
@vladislav-ryzhov vladislav-ryzhov changed the title [GooglePlayReleaseBundle]fix270 [GooglePlayReleaseBundle]Add changesNotSentForReview option May 20, 2021
@vladislav-ryzhov vladislav-ryzhov merged commit 43cd047 into master May 20, 2021
@Wychell
Copy link

Wychell commented May 27, 2021

Do you have a forecast for a new relase? or do we have any other option to meet this need?

@anatolybolshakov
Copy link
Contributor

Hi @Wychell we are planning to release it approximately next week.

@nasaleanhorea
Copy link

Hello , i am trying to set the flag changesNotSentForReview in my VSTS extension but can't see the checkbox

image

@EzzhevNikita
Copy link
Contributor

@nasaleanhorea Which version of the GooglePlayReleaseBundle task is used in your pipeline?

@nasaleanhorea
Copy link

@EzzhevNikita 3.*

@EzzhevNikita
Copy link
Contributor

@nasaleanhorea Could you please check the version of the extension in organization settings: General => Extensions => Google play and please share the Installed version from Extension details block.

@nasaleanhorea
Copy link

image

so 3.189.0

@EzzhevNikita
Copy link
Contributor

@nasaleanhorea Oh wait, just noticed, on the first screen you are using Google Play - Release task, while we have added changesNotSentForReview option for Google Play - Release Bundle task

@nasaleanhorea
Copy link

yea .. just noticed as well .. :) sorry for the confusion .. Will it be available for the Google Play - Release task in the future ?

@EzzhevNikita
Copy link
Contributor

As far as I know, we don't have a related ticket in this repo. So if it is required for you, you can create a future request ticket in this repo and we will take a look at the possibility of adding this option for Google Play - Release task also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants