Skip to content

Upgrade backends #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025
Merged

Upgrade backends #1596

merged 11 commits into from
Apr 22, 2025

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Mar 19, 2025

This PR upgrades the three backends. This is a summary of the changes:

@qmuntal qmuntal requested review from karianna, dagood, mertakman, gdams and a user March 19, 2025 14:02
@qmuntal qmuntal requested a review from a team as a code owner March 19, 2025 14:02
gdams
gdams previously approved these changes Mar 19, 2025
@qmuntal qmuntal enabled auto-merge (squash) March 19, 2025 14:07
@dagood
Copy link
Member

dagood commented Mar 19, 2025

Some unexpected allocations, and some that look like they're missing info in the test browser, but maybe I'm just not familiar:

=== RUN   TestGeneratedHash
    shared_test.go:89: go install -buildmode=shared -linkshared ./issue30768/issue30768lib
    shared_test.go:1125: executing /__w/1/s/go/bin/go test -linkshared ./issue30768 failed exit status 1:
--- FAIL: TestGeneratedHash (5.32s)

@qmuntal
Copy link
Member Author

qmuntal commented Mar 20, 2025

Some unexpected allocations

Filled microsoft/go-crypto-darwin#43.

and some that look like they're missing info in the test browser, but maybe I'm just not familiar:

Can reproduce this locally. This is the only info reported by the test, unfortunately. Sent https://go-review.googlesource.com/c/go/+/659456 to add the missing context.

@qmuntal
Copy link
Member Author

qmuntal commented Mar 20, 2025

Submitted golang-fips/openssl#268 to fix the AZL3 issue.

@qmuntal qmuntal closed this Apr 14, 2025
auto-merge was automatically disabled April 14, 2025 07:25

Pull request was closed

@qmuntal qmuntal force-pushed the dev/qmuntal/bumpdeps branch from 254869f to 4ee485c Compare April 14, 2025 07:25
@qmuntal qmuntal reopened this Apr 14, 2025
@qmuntal
Copy link
Member Author

qmuntal commented Apr 14, 2025

There are two outstanding failures:

@dagood
Copy link
Member

dagood commented Apr 14, 2025

@qmuntal
Copy link
Member Author

qmuntal commented Apr 15, 2025

Looks like it still happened: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1015443&view=ms.vss-test-web.build-test-results-tab&runId=27170570&paneView=debug&resultId=155368

Yep, that commit fixed the Ubuntu, Mariner 2, and AZL 3 builds, but Mariner 1 is still failing with the same error. I can't reproduce it locally using the same base image, weird. Don't know if it worth investigating given #1634.

Darwin is also timing out...

@mertakman
Copy link
Contributor

Looks like it still happened: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1015443&view=ms.vss-test-web.build-test-results-tab&runId=27170570&paneView=debug&resultId=155368

Yep, that commit fixed the Ubuntu, Mariner 2, and AZL 3 builds, but Mariner 1 is still failing with the same error. I can't reproduce it locally using the same base image, weird. Don't know if it worth investigating given #1634.

Darwin is also timing out...

Mariner 1.1 is at end of life, should we drop support to that?

@qmuntal qmuntal force-pushed the dev/qmuntal/bumpdeps branch from 3a65967 to 9b7e064 Compare April 22, 2025 08:40
@qmuntal qmuntal requested a review from gdams April 22, 2025 14:23
@qmuntal
Copy link
Member Author

qmuntal commented Apr 22, 2025

Finally manage to make CI happy without skipping any test 😄 .

@qmuntal qmuntal merged commit 153fd99 into microsoft/main Apr 22, 2025
35 checks passed
@qmuntal qmuntal deleted the dev/qmuntal/bumpdeps branch April 22, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants