-
Notifications
You must be signed in to change notification settings - Fork 32
Upgrade backends #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade backends #1596
Conversation
Some
|
Filled microsoft/go-crypto-darwin#43.
Can reproduce this locally. This is the only info reported by the test, unfortunately. Sent https://go-review.googlesource.com/c/go/+/659456 to add the missing context. |
Submitted golang-fips/openssl#268 to fix the AZL3 issue. |
Pull request was closed
254869f
to
4ee485c
Compare
There are two outstanding failures:
|
Looks like it still happened: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1015443&view=ms.vss-test-web.build-test-results-tab&runId=27170570&paneView=debug&resultId=155368 |
Yep, that commit fixed the Ubuntu, Mariner 2, and AZL 3 builds, but Mariner 1 is still failing with the same error. I can't reproduce it locally using the same base image, weird. Don't know if it worth investigating given #1634. Darwin is also timing out... |
Mariner 1.1 is at end of life, should we drop support to that? |
3a65967
to
9b7e064
Compare
Finally manage to make CI happy without skipping any test 😄 . |
This PR upgrades the three backends. This is a summary of the changes:
encoding/binary
, so we can drop it fromTestDependencies
. Don't use encoding/binary go-crypto-winnative#90 and Don't use encoding/binary golang-fips/openssl#257.