Skip to content

lowercase module name #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

lowercase module name #159

wants to merge 1 commit into from

Conversation

balboah
Copy link

@balboah balboah commented Sep 12, 2019

Breaks builds on non-windows,

parsing go.mod: unexpected module path "github.com/Microsoft/go-winio"

Fixes #156

Breaks builds on non-windows,

`parsing go.mod: unexpected module path "github.com/Microsoft/go-winio"`
@noxer
Copy link

noxer commented Oct 7, 2019

The problems occur on case sensitive file systems. Some of the microsoft packages use package names with Microsoft, some with microsoft which also leads to problems when modules are vendored on one file system and then copied to another one.

@TBBle
Copy link
Contributor

TBBle commented Jan 2, 2021

I feel like this change would needlessly break users who are using github.com/Microsoft/go-winio as an import correctly, instead of trying to go via github.com/microsoft/go-winio as seen in #156.

@kevpar
Copy link
Member

kevpar commented Jan 5, 2021

I agree that this would be too disruptive to existing users to change the module name to lower-case. I think a good change to improve the state of things would be to add a canonical import path of github.com/Microsoft/go-winio to the files in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-winio module problem
4 participants