-
Notifications
You must be signed in to change notification settings - Fork 69
RPM/Yum/Zypper/Centos/Fedora/Suse packages #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for putting this together!
Let's convert package.yml into a template that we include in the build-product.yml
as a step or separate job. We should be able to use the same bits in the Github release as the rpm.
cc9d4c8
to
a837ff3
Compare
I've created package-product|common-create|common-test.yml. I'll do something similar for the publish part (presuming it's possible), then I'll create a pipeline to chain the 3 together. This keeps each .yml file doing one thing only. |
- task: DownloadPipelineArtifact@2 | ||
inputs: | ||
source: 'specific' | ||
project: 'ae14e11c-7eb2-46af-b588-471e6116d635' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be a friendly name instead of a guid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is it better to obfuscate our ADO names in the public repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help says either:
Project | (Required) The project name or GUID from which to download the pipeline artifacts.
I am open either way. I think this can be the project name. Let me think on this.
matrix: | ||
rpm: | ||
imageName: 'ubuntu-latest' | ||
os: linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this entire stack is Linux-specific. Won't we need powershell or cmd scripts for Windows, and use a different signing profile?
Perhaps the template names should be based on the OS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think docker and mac can follow this format, I think windows is the only odd one out. I was planning to deal with that when I get to the Windows PR, and make the fewest possible changes when I get to the Windows PR (it might just come down to pipeline.sh vs pipeline.cmd etc.!
@@ -0,0 +1,30 @@ | |||
# sqlcmd package pipeline | |||
|
|||
pr: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a trigger based on the product build pipeline per https://docs.microsoft.com/en-us/azure/devops/pipelines/process/resources?view=azure-devops&tabs=schema#define-a-pipelines-resource ?
This PR builds and signs the sqlcmd .rpm package for Yum (Centos/Fedora) and Zypper (OpenSuse) and tests the package for the following base images: centos:centos7 centos:centos8 fedora:29 fedora:30 fedora:31 opensuse/leap.
The PR is designed to work both directly in the local repo and Azure Dev Ops.
This PR is part of a series of 5 initial PRs that will provide packages for all the common managers on the common OSes (Linux, Windows and Mac). Follow up PRs will provide packages for less common configs.
Execute the following command from the root directory of this repository:
./release/linux/rpm/pipeline.sh
Output will be sent to
./output/rpm
To test the packages:
./release/linux/rpm/pipeline-test.sh
A follow up PR will publish the .rpms to packages.microsoft.com for public download