Skip to content

fix: resolve vars in error and out commands #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix: resolve vars in error and out commands #535

merged 3 commits into from
Jun 4, 2024

Conversation

shueybubbles
Copy link
Collaborator

Fixes #522

apoorvdeshmukh
apoorvdeshmukh approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test case for this one? Fix looks good!

@shueybubbles shueybubbles merged commit f78b382 into main Jun 4, 2024
@shueybubbles shueybubbles deleted the shueybubbles/522 branch June 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

@stuartpa stuartpa stuartpa approved these changes

@kenvanhyning kenvanhyning Awaiting requested review from kenvanhyning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scripting variables are not expanded in :out and :r commands
3 participants
@shueybubbles @apoorvdeshmukh @stuartpa