Skip to content

Fix: Miscellaneous ODBC compatibility fixes #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2023
Merged

Fix: Miscellaneous ODBC compatibility fixes #397

merged 7 commits into from
Jun 30, 2023

Conversation

shueybubbles
Copy link
Collaborator

Fixes #394
Fixes #395
Fixes #396

  • Preserve blank lines in the batch
  • Add procedure name to errors when appropriate
  • Stub out -I and -R flags so they are allowed in scripts but have no effect on execution

apoorvdeshmukh
apoorvdeshmukh approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles shueybubbles merged commit f504ba6 into main Jun 30, 2023
@shueybubbles shueybubbles deleted the shueybubbles/396-395-394 branch June 30, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

@JyotikaGargg JyotikaGargg Awaiting requested review from JyotikaGargg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go-sqlcmd does not report procedure name go-sqlcmd reports incorrect line numbers (because it strips blank lines) Restore -I as a no-op
2 participants
@shueybubbles @apoorvdeshmukh