Set http.version=HTTP/1.1 in supports_gvfs_protocol()#759
Merged
dscho merged 1 commit intovfs-2.49.0from May 27, 2025
Merged
Conversation
The way the `gvfs-helper` command operates is apparently incompatible with HTTP/2, that's why #754 tried to enforce HTTP/1.1 in Scalar clones accessing Azure Repos. However, this fix was incomplete for the `scalar clone` part because it made the HTTP/1.1 enforcement contingent on the test whether the remote repository supports the GVFS protocol or not, and that test did _not_ enforce HTTP/1.1. Let's fix that Catch-22 by enforcing HTTP/1.1 usage during that GVFS Protocol capability test. Reported-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
derrickstolee
approved these changes
May 27, 2025
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
It's nice that we can be explicit here, making this an obviously-correct change that will not affect the other code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the
gvfs-helpercommand operates is apparently incompatible with HTTP/2, that's why #754 tried to enforce HTTP/1.1 in Scalar clones accessing Azure Repos.However, this fix was incomplete for the
scalar clonepart because it made the HTTP/1.1 enforcement contingent on the test whether the remote repository supports the GVFS protocol or not, and that test did not enforce HTTP/1.1.Let's fix that Catch-22 by enforcing HTTP/1.1 usage during that GVFS Protocol capability test.