Skip to content

gvfs-helper: retry when creating temp files #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2019
Merged

gvfs-helper: retry when creating temp files #231

merged 1 commit into from
Dec 31, 2019

Conversation

@derrickstolee
Copy link

@derrickstolee derrickstolee commented Dec 26, 2019

When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-" suffix to the
name before the ".temp".

This is a follow-up to #229.

@derrickstolee
gvfs-helper: retry when creating temp files
789f5dd 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee mentioned this pull request Dec 26, 2019
Merged
jeffhostetler
jeffhostetler approved these changes Dec 30, 2019
View reviewed changes
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! We got a collision in the concurrent test suite even with the microsecond value in the basename.

@jeffhostetler
Copy link

jeffhostetler commented Dec 30, 2019

as an alternative, we could encode the PID in the tempfile pathname.

@derrickstolee derrickstolee merged commit ccc87aa into microsoft:vfs-2.24.1 Dec 31, 2019
derrickstolee added a commit to microsoft/scalar that referenced this pull request Dec 31, 2019
@derrickstolee
Merge pull request #267: Update Git to include concurrent pack-file fix
da9868e 
These updates allow the gvfs-helper to be more resilient to concurrent pack downloads.

See microsoft/git#229 and microsoft/git#231 for more details.
derrickstolee added a commit that referenced this pull request Jan 14, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
8799930 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Feb 21, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
3b9ff2a 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Mar 17, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
f650135 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Mar 23, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
811c65f 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
dscho pushed a commit that referenced this pull request May 20, 2020
@derrickstolee @dscho
Merge pull request #231: gvfs-helper: retry when creating temp files
63f7f64 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
dscho pushed a commit that referenced this pull request May 20, 2020
@derrickstolee @dscho
Merge pull request #231: gvfs-helper: retry when creating temp files
1f6c438 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Jun 1, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
b0950dc 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 20, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
0a4e78d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 27, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
24dfc0d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 28, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
17ff6eb 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 6, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
a2e1c7e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 6, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
852db15 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 6, 2020
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
982a3d1 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 9, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
8dfbaf4 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jan 1, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
4324052 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Feb 10, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
9198c57 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Feb 27, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
e4ee187 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Mar 5, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
9be0218 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Mar 5, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
7456b4f 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Mar 12, 2025
@derrickstolee @mjcheetham
Merge gvfs-helper prefetch feature
2be41f6 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Mar 17, 2025
@derrickstolee @mjcheetham
Merge gvfs-helper prefetch feature
079e20a 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 6, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
5e09799 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 6, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
71c406c 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 11, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
8d3beae 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 13, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
3ecc804 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
03e5443 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b341913 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b204bc8 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 8, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
52da1e4 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 5, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
4848931 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 5, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
e00d671 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 8, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
6fe35fa 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 8, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
3ff6d8e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 13, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
c108c44 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 19, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
6dc900a 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
00082df 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b6e2d5a 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
a05801e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 28, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
4fae44f 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 5, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
08b23d6 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 6, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
05eb2d9 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 6, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
0711e82 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 13, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b5e6d01 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 17, 2025
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
2c5915f 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffhostetler jeffhostetler jeffhostetler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derrickstolee @jeffhostetler