test-gvfs-protocol.c, t5799-gvfs-helper.sh: unit tests for gvfs-helper #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
reviewed
Nov 1, 2019
jeffhostetler
force-pushed
the
users/jeffhost/test-gvfs-helper
branch
from
08a1550 to
7577012
Compare
jeffhostetler
changed the title
jeffhostetler
requested review from
dscho,
derrickstolee,
garimasi514,
jrbriggs,
kewillford and
wilbaker
wilbaker
reviewed
Nov 8, 2019
Create t/helper/test-gvfs-protocol.c and t/t5799-gvfs-helper.sh to test gvfs-helper. Create t/helper/test-gvfs-protocol.c as a stand-alone web server that speaks the GVFS Protocol [1] and serves loose objects and packfiles to clients. It is borrows heavily from the code in daemon.c. It includes a "mayhem" mode to cause various network and HTTP errors to test the retry/recovery ability of gvfs-helper. Create t/t5799-gvfs-helper.sh to test gvfs-helper. [1] https://github.com/microsoft/VFSForGit/blob/master/Protocol.md Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
jeffhostetler
force-pushed
the
users/jeffhost/test-gvfs-helper
branch
from
7577012 to
ad93507
Compare
|
I'm closing this PR based on 2.23 in favor of #220 which is based on 2.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[READY FOR REVIEW]
Git-style tests for gvfs-helper.
This series contains:
t/helper/test-gvfs-protocol, a test/mock HTTP server that speaks theGVFS Protocoland can return objects requested via the/gvfs/objects/[{oid}]GET and POST end-points. This will let us locally test thegvfs-helpermechanism to supply missing objects without the need for a remote Azure Repos or GVFS Cache-Server. And will let us drive full testing of the Git C layer on all platforms (before we do integration/functional testing of the VFS4G and peer C# layers).A Git-style test script
t/t5799-gvfs-helper.shwhich will exercise the above. Part 1 contains raw tests betweengvfs-helperandtest-gvfs-protocolin isolation. Part 2 does end-to-end integration tests starting with variousgit.execommands.BTW I forgot to rebase this on to features 2.24. I'll do that after we're happy with this version.