Added function getTimestampValue to handle nan value . #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anantk24
commented
Aug 24, 2021
anantk24
commented
- if value is NAN for timestamp , then it is considered as zero.
- added testcases for datetime constructor and nan value for timestamp.
- Defined hash code api - added null check and class check in equals api - Modified access modifiers according to JLS.
…ogs. - Updated command in maven github workflow. - Added default and contributor profile - Updated read me doc and contributing doc.
Minor edit for punctuation.
`mvn test` will still run, but does nothing. This would be surprising to anyone running this build. So I added back the `mvn test` line with some info about the contributor profile.
Contributor
Author
|
Closing this there is duplicate #50 . Created for test purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.