Fix VGETATTR and VSIM for large attributes#1520
Open
tiagonapoli wants to merge 308 commits intomainfrom
Open
Conversation
Collaborator
tiagonapoli
commented
Jan 29, 2026
tiagonapoli
commented
- Attributes larger than 2**17=131072, which is the size of the server send buffer, were causing tests to fail due to failure to send those over the connection
…nning, cleanup dispose logic accordingly
…); correcting some bad VADD error tests
…er alloc and copy on the search path
…ches and doesn't copy
…ets read/write/delete callbacks working _during_ index creation; this will simplify restoration and cleanup some stuff on the DiskANN side
…ill some failures due to internal id reuse, adding dedicated (and failing) tests for that
Co-authored-by: tiagonapoli <tiagonapoli@microsoft.com>
* Implement VGETATTR * Fix test * update comments * Minor refactor on test * ADdress comments * Fix format * Fix build * Handle unknown GarnetStatus --------- Co-authored-by: tiagonapoli <tiagonapoli@microsoft.com>
* DiskANN grid E2E tests * nit * Address comments --------- Co-authored-by: tiagonapoli <tiagonapoli@microsoft.com>
tiagonapoli
force-pushed
the
tiagonapoli/fix-vgetattr-large-attributes
branch
from
629ff64 to
349df54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.