ContextualMenu: Fix Narrator Separator Announcement#6876
Merged
JasonGore merged 2 commits intomicrosoft:masterfrom Oct 26, 2018
JasonGore:jg/6848-hide-separator
Merged
ContextualMenu: Fix Narrator Separator Announcement#6876JasonGore merged 2 commits intomicrosoft:masterfrom JasonGore:jg/6848-hide-separator
JasonGore merged 2 commits intomicrosoft:masterfrom
JasonGore:jg/6848-hide-separator
Conversation
joschect
approved these changes
Oct 26, 2018
18 tasks
Codecov Report
@@ Coverage Diff @@
## master #6876 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 858 858
Lines 24223 24223
Branches 5319 5319
=======================================
Hits 18130 18130
Misses 5646 5646
Partials 447 447
Continue to review full report at Codecov.
|
Contributor
|
🎉 Handy Links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Add
aria-hiddenattribute to separator to prevent announcement in Narrator's scan mode.Microsoft Reviewers: Open in CodeFlow