Skip to content

ContextualMenu: Fix Narrator Separator Announcement#6876

Merged
JasonGore merged 2 commits intomicrosoft:masterfrom
JasonGore:jg/6848-hide-separator
Oct 26, 2018
Merged

ContextualMenu: Fix Narrator Separator Announcement#6876
JasonGore merged 2 commits intomicrosoft:masterfrom
JasonGore:jg/6848-hide-separator

Conversation

@JasonGore
Copy link
Member

@JasonGore JasonGore commented Oct 26, 2018

Pull request checklist

Description of changes

Add aria-hidden attribute to separator to prevent announcement in Narrator's scan mode.

Microsoft Reviewers: Open in CodeFlow

@TestAccessibilityGIT TestAccessibilityGIT mentioned this pull request Oct 26, 2018
18 tasks
@codecov-io
Copy link

Codecov Report

Merging #6876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6876   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files         858      858           
  Lines       24223    24223           
  Branches     5319     5319           
=======================================
  Hits        18130    18130           
  Misses       5646     5646           
  Partials      447      447
Impacted Files Coverage Δ
.../components/ContextualMenu/ContextualMenu.base.tsx 74.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de1a78...af21008. Read the comment docs.

@JasonGore JasonGore merged commit 866caf6 into microsoft:master Oct 26, 2018
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v6.93.1 has been released which incorporates this pull request.:tada:

Handy Links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Narrator announces the ContextualMenu separator

4 participants