Focustrapzone last child focuszone 2#6688
Closed
SpencerLynn wants to merge 2 commits intomicrosoft:masterfrom
Closed
Focustrapzone last child focuszone 2#6688SpencerLynn wants to merge 2 commits intomicrosoft:masterfrom
SpencerLynn wants to merge 2 commits intomicrosoft:masterfrom
Conversation
…a FocusZone was the last element in the trap zone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Handling the case where a FocusTrapZone would not properly trap when a FocusZone was the last element in the trap zone.
When finding the last tabbable element in a FocusTrapZone, if we run across a FocusZone, we can just find the first tabbable element inside, since FocusZones can only have one element active at a time.
Focus areas to test
This is a second attempt to fix this issue - see previous PR #4172, which was reverted due to issues in other components. I have manually tested the DetailsList, but would greatly appreciate further testing.
FYI: @dzearing and @joschect since they were part of the initial discussion prompting the revert.
Microsoft Reviewers: Open in CodeFlow