Fix a11y violations reported in ContextualMenu examples#6574
Merged
micahgodbolt merged 6 commits intomicrosoft:masterfrom Oct 8, 2018
Merged
Fix a11y violations reported in ContextualMenu examples#6574micahgodbolt merged 6 commits intomicrosoft:masterfrom
micahgodbolt merged 6 commits intomicrosoft:masterfrom
Conversation
…ter CtxMenu example
natalieethell
approved these changes
Oct 5, 2018
Contributor
|
Looks like snapshots just need to be updated. |
Contributor
|
🎉 Handy Links: |
18 tasks
Contributor
|
🎉 Handy Links: |
Member
Author
|
Part of #6360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
This PR addresses the a11y violations for
ContextualMenuexamples. There is no impact to the lib, but they were flagged in #6360 so we opted to address them so folks don't copy invalid code.Fixes:
ContextualMenucomponent a11y fixes to follow in subsequent PR.Focus areas to test
ContextualMenuexample pages.aria-labeldefined.Microsoft Reviewers: Open in CodeFlow