Skip to content

Searchbox: deprecate defaultValue #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Mar 27, 2018
Merged

Searchbox: deprecate defaultValue #4225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ba10b
Deprecate SearchBox defaultValue prop.
Mar 9, 2018
92e776a
npm run change output
Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...on/changes/office-ui-fabric-react/searchbox--deprecate-defaultValue_2018-03-09-20-24.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Deprecate SearchBox defaultValue prop.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-jojanz@microsoft.com"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export class SearchBoxBase extends BaseComponent<ISearchBoxProps, ISearchBoxStat
super(props);

this._warnDeprecations({
'labelText': 'placeholder'
'labelText': 'placeholder',
'defaultValue': 'value'
});

this._latestValue = props.value || '';
Expand Down
3 changes: 3 additions & 0 deletions packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ export interface ISearchBoxProps extends React.InputHTMLAttributes<HTMLInputElem

/**
* The default value of the text in the SearchBox, in the case of an uncontrolled component.
* Up till now, this has not been implemented, deprecating. Will re-implement if uncontrolled
* component behavior is implemented.
* @deprecated
*/
defaultValue?: string;

Expand Down