fix(web-components): support middle-click to open links in new tab (Fixes #36567) - #36569
Open
water (waterWang) wants to merge 1 commit into
Open
fix(web-components): support middle-click to open links in new tab (Fixes #36567)#36569water (waterWang) wants to merge 1 commit into
water (waterWang) wants to merge 1 commit into
Conversation
fluent-link and fluent-anchor-button did not respond to middle mouse button clicks. The `@click` event only fires for left-button clicks; middle-click triggers `auxclick`, which was not handled. Added an `auxclickHandler` method to BaseAnchor that opens the link in a new tab when the middle mouse button (button === 1) is pressed. The anchor-button and link templates now bind `@auxclick` to this handler. Fixes microsoft#36567
|
water (@waterWang) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fluent-linkandfluent-anchor-buttondid not respond to middle mouse button clicks. The@clickevent only fires for left-button clicks; middle-click triggers theauxclickevent, which was not handled.When a user middle-clicks a native
<a>element, the browser opens the link in a new tab. These components should provide the same behavior.Changes
anchor-button.base.ts: AddedauxclickHandlermethod toBaseAnchorthat opens the link in a new tab when the middle mouse button (event.button === 1) is pressed.anchor-button.template.ts: Added@auxclickbinding to the template.link.template.ts: Added@auxclickbinding to the template (Link extends BaseAnchor, so it inherits the handler).Testing
fluent-linkwithhref→ opens in new tabfluent-anchor-buttonwithhref→ opens in new tabFixes #36567