Skip to content

Conversation

marcosmoura
Copy link
Contributor

@marcosmoura marcosmoura commented Sep 19, 2025

Previous Behavior

Dialog will always unmount the DOM element on close.

New Behavior

Dialog now has a new prop (unmountOnClose) to keep the element mounted on close, allowing the Dialog to restore its state when opening again

Related Issue(s)

Copy link

github-actions bot commented Sep 19, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.284 MB
323.482 kB
1.285 MB
323.585 kB
312 B
103 B
react-dialog
Dialog (including children components)
103.578 kB
30.891 kB
103.665 kB
30.924 kB
87 B
33 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.796 kB
19.903 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
236.943 kB
68.636 kB
react-components
react-components: FluentProvider & webLightTheme
43.63 kB
14.257 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
react-timepicker-compat
TimePicker
109.935 kB
36.335 kB
🤖 This report was generated against e07b2b9254f0434c16258080a5302cd81946d3c3

Copy link

Pull request demo site: URL

@marcosmoura marcosmoura changed the title EXPERIMENTAL: feat(react-dialog): add support to keep dialog mounted on close feat(react-dialog): add support to keep dialog mounted on close Sep 19, 2025
@marcosmoura marcosmoura marked this pull request as ready for review September 19, 2025 15:31
@marcosmoura marcosmoura requested a review from a team as a code owner September 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant