Skip to content

update Menu to use HTML Popover API #35205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

update Menu to use HTML Popover API #35205

wants to merge 1 commit into from

Conversation

spmonahan
Copy link
Contributor

Just for testing, breaks the API and only the base case is tested.

@spmonahan
update Menu to use HTML Popover API
ca57b22 
Just for testing, breaks the API and only the base case is tested.
@spmonahan spmonahan requested review from a team as code owners September 17, 2025 18:17
@github-actions GitHub Actions
Copy link

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)		 108.537 kB
33.183 kB		 108.623 kB
33.207 kB		 86 B
24 B
react-avatar
Avatar		 48.518 kB
15.508 kB		 48.604 kB
15.533 kB		 86 B
25 B
react-avatar
AvatarGroup		 19.235 kB
7.617 kB		 19.321 kB
7.638 kB		 86 B
21 B
react-avatar
AvatarGroupItem		 62.662 kB
19.727 kB		 62.748 kB
19.752 kB		 86 B
25 B
react-badge
Badge		 25.089 kB
8.256 kB		 25.175 kB
8.277 kB		 86 B
21 B
react-badge
CounterBadge		 25.869 kB
8.53 kB		 25.955 kB
8.551 kB		 86 B
21 B
react-badge
PresenceBadge		 24.929 kB
9.147 kB		 25.015 kB
9.169 kB		 86 B
22 B
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.22 kB
31.522 kB		 114.306 kB
31.542 kB		 86 B
20 B
react-button
Button		 36.705 kB
10.508 kB		 36.791 kB
10.527 kB		 86 B
19 B
react-button
CompoundButton		 43.117 kB
11.812 kB		 43.203 kB
11.832 kB		 86 B
20 B
react-button
MenuButton		 41.6 kB
11.902 kB		 41.686 kB
11.922 kB		 86 B
20 B
react-button
SplitButton		 49.667 kB
13.477 kB		 49.753 kB
13.499 kB		 86 B
22 B
react-button
ToggleButton		 52.636 kB
12.285 kB		 52.722 kB
12.304 kB		 86 B
19 B
react-card
Card - All		 106.044 kB
29.799 kB		 106.13 kB
29.819 kB		 86 B
20 B
react-card
Card		 98.69 kB
27.924 kB		 98.776 kB
27.943 kB		 86 B
19 B
react-card
CardFooter		 13.662 kB
5.517 kB		 13.748 kB
5.538 kB		 86 B
21 B
react-card
CardHeader		 16.195 kB
6.38 kB		 16.281 kB
6.402 kB		 86 B
22 B
react-card
CardPreview		 13.729 kB
5.645 kB		 13.815 kB
5.664 kB		 86 B
19 B
react-charts
AreaChart		 384.401 kB
117.185 kB		 384.798 kB
117.354 kB		 397 B
169 B
react-charts
DeclarativeChart		 680.855 kB
195.479 kB		 681.258 kB
196.664 kB		 403 B
1.185 kB
react-charts
DonutChart		 296.516 kB
88.592 kB		 296.914 kB
89.757 kB		 398 B
1.165 kB
react-charts
FunnelChart		 287.743 kB
85.563 kB		 288.14 kB
86.593 kB		 397 B
1.03 kB
react-charts
GanttChart		 367.639 kB
110.699 kB		 368.043 kB
111.398 kB		 404 B
699 B
react-charts
GaugeChart		 310.819 kB
92.091 kB		 311.222 kB
92.353 kB		 403 B
262 B
react-charts
GroupedVerticalBarChart		 371.17 kB
111.809 kB		 371.573 kB
112.53 kB		 403 B
721 B
react-charts
HeatMapChart		 369.667 kB
112.316 kB		 370.064 kB
112.482 kB		 397 B
166 B
react-charts
HorizontalBarChart		 295.272 kB
86.894 kB		 295.669 kB
87.163 kB		 397 B
269 B
react-charts
Legends		 234.845 kB
69.479 kB		 201.733 kB
58.116 kB		 -33.112 kB
-11.363 kB
react-charts
LineChart		 393.906 kB
118.73 kB		 394.309 kB
119.21 kB		 403 B
480 B
react-charts
SankeyChart		 198.839 kB
61.09 kB		 198.925 kB
61.118 kB		 86 B
28 B
react-charts
ScatterChart		 375.426 kB
113.248 kB		 375.829 kB
114.006 kB		 403 B
758 B
react-charts
VerticalBarChart		 410.24 kB
118.79 kB		 410.637 kB
118.986 kB		 397 B
196 B
react-charts
VerticalStackedBarChart		 382.06 kB
114.654 kB		 382.463 kB
115.689 kB		 403 B
1.035 kB
react-checkbox
Checkbox		 34.335 kB
11.786 kB		 34.421 kB
11.805 kB		 86 B
19 B
react-color-picker
ColorArea		 49.32 kB
17.32 kB		 49.406 kB
17.343 kB		 86 B
23 B
react-color-picker
ColorPicker		 17.95 kB
7.143 kB		 18.036 kB
7.165 kB		 86 B
22 B
react-color-picker
ColorSlider		 41.493 kB
15.375 kB		 41.579 kB
15.399 kB		 86 B
24 B
react-combobox
Combobox (including child components)		 106.952 kB
34.798 kB		 107.038 kB
34.817 kB		 86 B
19 B
react-combobox
Dropdown (including child components)		 107.582 kB
34.719 kB		 107.668 kB
34.742 kB		 86 B
23 B
react-components
react-components: Button, FluentProvider & webLightTheme		 68.796 kB
19.903 kB		 68.882 kB
19.925 kB		 86 B
22 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 236.691 kB
68.567 kB		 237.091 kB
68.947 kB		 400 B
380 B
react-components
react-components: FluentProvider & webLightTheme		 43.63 kB
14.257 kB		 43.716 kB
14.279 kB		 86 B
22 B
react-components
react-components: entire library		 1.284 MB
323.352 kB		 1.284 MB
323.54 kB		 401 B
188 B
react-datepicker-compat
DatePicker Compat		 226.653 kB
64.089 kB		 226.739 kB
64.108 kB		 86 B
19 B
react-dialog
Dialog (including children components)		 103.578 kB
30.891 kB		 103.664 kB
30.915 kB		 86 B
24 B
react-divider
Divider		 20.626 kB
7.654 kB		 20.712 kB
7.677 kB		 86 B
23 B
react-field
Field		 22.657 kB
8.602 kB		 22.741 kB
8.619 kB		 84 B
17 B
react-image
Image		 14.473 kB
5.919 kB		 14.559 kB
5.943 kB		 86 B
24 B
react-input
Input		 27.148 kB
9.108 kB		 27.234 kB
9.128 kB		 86 B
20 B
react-label
Label		 13.799 kB
5.644 kB		 13.885 kB
5.666 kB		 86 B
22 B
react-link
Link		 16.746 kB
6.785 kB		 16.832 kB
6.807 kB		 86 B
22 B
react-list
List		 88.922 kB
26.387 kB		 89.008 kB
26.406 kB		 86 B
19 B
react-list
ListItem		 112.381 kB
33.224 kB		 112.467 kB
33.25 kB		 86 B
26 B
react-menu
Menu (including children components)		 165.115 kB
49.994 kB		 132.084 kB
39.126 kB		 -33.031 kB
-10.868 kB
react-menu
Menu (including selectable components)		 168.097 kB
50.588 kB		 135.054 kB
39.664 kB		 -33.043 kB
-10.924 kB
react-message-bar
MessageBar (all components)		 24.088 kB
8.96 kB		 24.174 kB
8.981 kB		 86 B
21 B
react-persona
Persona		 55.409 kB
17.389 kB		 55.495 kB
17.413 kB		 86 B
24 B
react-popover
Popover		 132.3 kB
41.178 kB		 132.386 kB
41.2 kB		 86 B
22 B
react-progress
ProgressBar		 16.593 kB
6.613 kB		 16.679 kB
6.635 kB		 86 B
22 B
react-provider
FluentProvider		 23.806 kB
8.557 kB		 23.892 kB
8.579 kB		 86 B
22 B
react-radio
Radio		 31.8 kB
10.006 kB		 31.886 kB
10.026 kB		 86 B
20 B
react-radio
RadioGroup		 14.889 kB
6.09 kB		 14.975 kB
6.11 kB		 86 B
20 B
react-select
Select		 26.95 kB
9.833 kB		 27.036 kB
9.855 kB		 86 B
22 B
react-slider
Slider		 37.211 kB
12.461 kB		 37.297 kB
12.482 kB		 86 B
21 B
react-spinbutton
SpinButton		 34.431 kB
11.449 kB		 34.517 kB
11.469 kB		 86 B
20 B
react-spinner
Spinner		 24.396 kB
8.201 kB		 24.482 kB
8.223 kB		 86 B
22 B
react-swatch-picker
@fluentui/react-swatch-picker - package		 106.047 kB
30.539 kB		 106.133 kB
30.564 kB		 86 B
25 B
react-switch
Switch		 34.51 kB
11.014 kB		 34.596 kB
11.037 kB		 86 B
23 B
react-table
DataGrid		 161.061 kB
45.539 kB		 161.147 kB
45.56 kB		 86 B
21 B
react-table
Table (Primitives only)		 41.978 kB
13.573 kB		 42.064 kB
13.593 kB		 86 B
20 B
react-table
Table as DataGrid		 131.484 kB
36.345 kB		 131.57 kB
36.369 kB		 86 B
24 B
react-table
Table (Selection only)		 69.846 kB
19.704 kB		 69.932 kB
19.725 kB		 86 B
21 B
react-table
Table (Sort only)		 68.489 kB
19.321 kB		 68.575 kB
19.342 kB		 86 B
21 B
react-tag-picker
@fluentui/react-tag-picker - package		 188.33 kB
56.457 kB		 188.416 kB
56.485 kB		 86 B
28 B
react-tags
InteractionTag		 14.561 kB
5.865 kB		 14.647 kB
5.887 kB		 86 B
22 B
react-tags
Tag		 30.379 kB
9.779 kB		 30.465 kB
9.8 kB		 86 B
21 B
react-tags
TagGroup		 83.125 kB
24.561 kB		 83.211 kB
24.579 kB		 86 B
18 B
react-text
Text - Default		 16.19 kB
6.366 kB		 16.276 kB
6.386 kB		 86 B
20 B
react-text
Text - Wrappers		 19.35 kB
6.695 kB		 19.436 kB
6.714 kB		 86 B
19 B
react-textarea
Textarea		 25.53 kB
9.361 kB		 25.616 kB
9.381 kB		 86 B
20 B
react-timepicker-compat
TimePicker		 109.935 kB
36.335 kB		 110.021 kB
36.358 kB		 86 B
23 B
react-toast
Toast (including Toaster)		 103.665 kB
31.028 kB		 103.751 kB
31.049 kB		 86 B
21 B
react-tree
FlatTree		 149.326 kB
42.711 kB		 149.412 kB
42.733 kB		 86 B
22 B
react-tree
PersonaFlatTree		 150.082 kB
42.837 kB		 150.168 kB
42.858 kB		 86 B
21 B
react-tree
PersonaTree		 146.34 kB
41.686 kB		 146.426 kB
41.711 kB		 86 B
25 B
react-tree
Tree		 145.588 kB
41.562 kB		 145.674 kB
41.587 kB		 86 B
25 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
react-aria
ARIA - Default		 237 B
181 B
react-calendar-compat
Calendar Compat		 149.782 kB
39.934 kB
react-charts
HorizontalBarChartWithAxis		 63 B
83 B
react-charts
Sparkline		 91.123 kB
28.692 kB
react-jsx-runtime
Classic Pragma		 1.101 kB
550 B
react-jsx-runtime
JSX Dev Runtime		 2.8 kB
1.251 kB
react-jsx-runtime
JSX Runtime		 3.422 kB
1.493 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.109 kB
1.806 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 5.771 kB
2.396 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.727 kB
823 B
react-overflow
hooks only		 12.854 kB
4.828 kB
react-portal
Portal		 15.411 kB
5.385 kB
react-portal-compat
PortalCompatProvider		 8.386 kB
2.624 kB
react-positioning
usePositioning		 28.865 kB
10.146 kB
react-positioning
useSafeZoneArea		 12.29 kB
4.967 kB
react-teaching-popover
TeachingPopover		 102.777 kB
30.738 kB
react-tooltip
Tooltip		 57.922 kB
20.084 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against b41d8a3d8aca02f9cd38e77c373dec24d238c41d

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@tudorpopams tudorpopams marked this pull request as draft September 23, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Do Not Merge 🚫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spmonahan @Hotell