-
Notifications
You must be signed in to change notification settings - Fork 2.8k
TEST: update to target ES2022 from ES2019 #35193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spmonahan
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
spmonahan:update-to-es2022-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all tsconfigs and swcrcs for react-components packages.
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
"transform": { | ||
"react": { | ||
"runtime": "classic", | ||
"useSpread": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Drawer.overlay drawer full - High Contrast.chromium.png | 4942 | Changed |
vr-tests-react-components/Positioning 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 311 | Changed |
vr-tests-react-components/Positioning.Positioning end.chromium.png | 702 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
vr-tests-web-components/Avatar 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png | 10381 | Changed |
vr-tests-web-components/Badge 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 444 | Changed |
vr-tests-web-components/MenuList 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
vr-tests-web-components/Switch 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests-web-components/Switch. - Dark Mode.normal.chromium_1.png | 92 | Changed |
vr-tests/Callout 13 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Callout.Left center.default.chromium.png | 2544 | Changed |
vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
vr-tests/Callout.Left top edge.default.chromium.png | 2168 | Changed |
vr-tests/Callout.Beak 25.default.chromium.png | 2185 | Changed |
vr-tests/Callout.Gap space 25.default.chromium.png | 2181 | Changed |
vr-tests/Callout.No beak.default.chromium.png | 2177 | Changed |
vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
vr-tests/Callout.Right bottom edge.default.chromium.png | 3037 | Changed |
vr-tests/Callout.Right center.default.chromium.png | 2080 | Changed |
vr-tests/Callout.Right top edge.default.chromium.png | 1116 | Changed |
vr-tests/Callout.Top center.default.chromium.png | 2113 | Changed |
vr-tests/Callout.Top right edge.default.chromium.png | 1134 | Changed |
vr-tests/Callout.Top left edge.default.chromium.png | 2196 | Changed |
vr-tests/Coachmark 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/Coachmark.Collapsed.default.chromium.png | 159 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-LineChart 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-LineChart.Events.default.chromium.png | 17 | Changed |
vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
we will bump to 2020, which should be the biggest delta ( cause by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a test to see how much of a bundle impact updating to ES2022 brings