-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Keytip passes through describedBy id if passed in #33048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Oct 15, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 618 | 617 | 5000 | |
Breadcrumb | mount | 1740 | 1699 | 1000 | |
Checkbox | mount | 1690 | 1700 | 5000 | |
CheckboxBase | mount | 1470 | 1492 | 5000 | |
ChoiceGroup | mount | 2936 | 2980 | 5000 | |
ComboBox | mount | 687 | 681 | 1000 | |
CommandBar | mount | 6649 | 6476 | 1000 | |
ContextualMenu | mount | 12050 | 12001 | 1000 | |
DefaultButton | mount | 797 | 787 | 5000 | |
DetailsRow | mount | 2262 | 2233 | 5000 | |
DetailsRowFast | mount | 2227 | 2213 | 5000 | |
DetailsRowNoStyles | mount | 2019 | 2050 | 5000 | |
Dialog | mount | 2852 | 2830 | 1000 | |
DocumentCardTitle | mount | 239 | 233 | 1000 | |
Dropdown | mount | 1997 | 2020 | 5000 | |
FocusTrapZone | mount | 1149 | 1154 | 5000 | |
FocusZone | mount | 1102 | 1082 | 5000 | |
GroupedList | mount | 42026 | 42289 | 2 | |
GroupedList | virtual-rerender | 20290 | 20361 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51334 | 51768 | 2 | |
GroupedListV2 | mount | 225 | 217 | 2 | |
GroupedListV2 | virtual-rerender | 218 | 212 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 225 | 230 | 2 | |
IconButton | mount | 1144 | 1145 | 5000 | |
Label | mount | 336 | 346 | 5000 | |
Layer | mount | 2734 | 2764 | 5000 | |
Link | mount | 398 | 387 | 5000 | |
MenuButton | mount | 983 | 1000 | 5000 | |
MessageBar | mount | 21566 | 21653 | 5000 | |
Nav | mount | 2040 | 2063 | 1000 | |
OverflowSet | mount | 792 | 776 | 5000 | |
Panel | mount | 1862 | 1817 | 1000 | |
Persona | mount | 730 | 750 | 1000 | |
Pivot | mount | 907 | 915 | 1000 | |
PrimaryButton | mount | 938 | 926 | 5000 | |
Rating | mount | 4608 | 4706 | 5000 | |
SearchBox | mount | 960 | 922 | 5000 | |
Shimmer | mount | 1870 | 1864 | 5000 | |
Slider | mount | 1348 | 1345 | 5000 | |
SpinButton | mount | 2955 | 2943 | 5000 | |
Spinner | mount | 397 | 402 | 5000 | |
SplitButton | mount | 1921 | 1853 | 5000 | |
Stack | mount | 418 | 431 | 5000 | |
StackWithIntrinsicChildren | mount | 886 | 879 | 5000 | |
StackWithTextChildren | mount | 2770 | 2796 | 5000 | |
SwatchColorPicker | mount | 6312 | 6384 | 5000 | |
TagPicker | mount | 1430 | 1443 | 5000 | |
Text | mount | 387 | 394 | 5000 | |
TextField | mount | 913 | 910 | 5000 | |
ThemeProvider | mount | 851 | 869 | 5000 | |
ThemeProvider | virtual-rerender | 584 | 582 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1285 | 1385 | 5000 | |
Toggle | mount | 599 | 622 | 5000 | |
buttonNative | mount | 196 | 185 | 5000 |
spmonahan
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In ContextualMenuItemAnchor and ContextualMenuItemButton, the
item.ariaDescription
'sid
was overridden and not correctly associated because the<KeytipData>
component would ignore theariaDescribedBy
prop and returnaria-describedby: undefined
if no keytip data was passed in.New Behavior
Keytip always returns the passed-in
ariaDescribedBy
id if present.Related Issue(s)