Carousel: Refactor CarouselAnnouncer #32896
Open
+114
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
...ents/react-carousel-preview/library/src/components/CarouselAnnouncer/useCarouselAnnouncer.ts
Outdated
Show resolved
Hide resolved
...ents/react-carousel-preview/library/src/components/CarouselAnnouncer/useCarouselAnnouncer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Should not we just use https://react.fluentui.dev/?path=/docs/utilities-aria-live-useannounce--docs?
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 646 | 647 | 5000 | |
| Button | mount | 307 | 301 | 5000 | |
| Field | mount | 1131 | 1135 | 5000 | |
| FluentProvider | mount | 711 | 729 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 77 | 82 | 10 | |
| MakeStyles | mount | 876 | 860 | 50000 | |
| Persona | mount | 1773 | 1797 | 5000 | |
| SpinButton | mount | 1403 | 1392 | 5000 | |
| SwatchPicker | mount | 1627 | 1664 | 5000 |
fabricteam
reviewed
Sep 24, 2024
change/@fluentui-react-aria-1b519f98-87ae-4fe2-be29-f46d1fe6fec4.json
Outdated
Show resolved
Hide resolved
Mitch-At-Work
force-pushed
the
user/mifraser/carousel-announcer-refactor
branch
from
ab21ee6
to
f81cca8
Compare
Mitch-At-Work
force-pushed
the
user/mifraser/carousel-announcer-refactor
branch
from
f81cca8
to
79ac345
Compare
...react-components/react-carousel-preview/stories/src/Carousel/CarouselActionCards.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel-preview/library/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const announcementText = announcement(activeIndex, totalNavLength.current, navGroupRef.current); | ||
|
|
||
| if (announcementTextRef.current === '') { |
There was a problem hiding this comment.
I believe that this will cause bugs in Strict Mode, https://react.dev/reference/react/StrictMode#fixing-bugs-found-by-double-rendering-in-development
packages/react-components/react-carousel-preview/library/src/components/Carousel/useCarousel.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
CarouselAnnouncer was driven via state, causing unnecessary re-renders.
New Behavior
CarouselAnnouncer driven by event updates that directly modify DOM.