Split Nav Item Implementation #32873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
mltejera
commented
Sep 25, 2024
...react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.types.ts
Outdated
Show resolved
Hide resolved
mltejera
commented
Sep 25, 2024
...react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.types.ts
Outdated
Show resolved
Hide resolved
mltejera
commented
Sep 25, 2024
...s/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx
Outdated
Show resolved
Hide resolved
mltejera
commented
Sep 25, 2024
...ages/react-components/react-nav-preview/stories/src/NavDrawer/NavDrawerSplitSize.stories.tsx
Outdated
Show resolved
Hide resolved
...s/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx
Show resolved
Hide resolved
Mitch-At-Work
approved these changes
Sep 26, 2024
mltejera
force-pushed
the
nav/build-out-split-nav-item
branch
from
0e9d13c
to
eb049a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactorings to the
@fluentui/react-nav-previewpackage, focusing primarily on theSplitNavItemcomponent. The most significant changes include the implementation of new slots forSplitNavItem, updates to its state and styles, and improvements to the associated tests and documentation.Enhancements to
SplitNavItemComponent:Implementation of New Slots:
navItem,actionButton,toggleButton, andmenuButtonto theSplitNavItemcomponent. (packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md,packages/react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.types.ts) [1] [2]SplitNavItemStateto include asizeproperty, defaulting to 'medium'. (packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md,packages/react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.types.ts) [1] [2]State and Rendering Updates:
useSplitNavItem_unstableto utilize the new slots and integrate withNavContext. (packages/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx)renderSplitNavItem_unstableto render the new slots conditionally. (packages/react-components/react-nav-preview/library/src/components/SplitNavItem/renderSplitNavItem.tsx)Styling and Class Name Enhancements:
useSplitNavItemStyles_unstableto apply styles to the new slots and updated class names. (packages/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItemStyles.styles.ts) [1] [2]packages/react-components/react-nav-preview/library/src/components/sharedNavStyles.styles.ts)Testing and Documentation:
SplitNavItemto include new slots and their expected class names. (packages/react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.test.tsx)SplitNavItem. (packages/react-components/react-nav-preview/library/src/components/SplitNavItem/__snapshots__/SplitNavItem.test.tsx.snap)Miscellaneous:
packages/react-components/react-nav-preview/stories/src/Nav/index.stories.tsx,packages/react-components/react-nav-preview/stories/src/NavDrawer/Basic.stories.tsx,packages/react-components/react-nav-preview/stories/src/NavDrawer/Controlled.stories.tsx) [1] [2] [3]These changes collectively enhance the functionality, maintainability, and test coverage of the
SplitNavItemcomponent within the@fluentui/react-nav-previewpackage.