Removed chartsV8 dependency from chartsV9 testcase files. #32869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtishayMsft
reviewed
Sep 19, 2024
| beforeEach(() => { | ||
| sharedBeforeEach(); | ||
|
|
||
| root = document.createElement('div'); |
There was a problem hiding this comment.
why removing this code
There was a problem hiding this comment.
I push the new updates; I revert back the previous code and now only removed the "sharedBeforeEach();" line.
Anush2303
reviewed
Sep 19, 2024
| afterEach(sharedAfterEach); | ||
|
|
||
| test('Should reflect theme change', () => { | ||
| // Arrange | ||
| const { container } = render( | ||
| <ThemeProvider theme={DarkTheme}> | ||
| <FluentProvider theme={{ colorNeutralBackground1: '#ccc' }}> |
There was a problem hiding this comment.
Which color does this #ccc represent? Like why are you checking for this specific color?
There was a problem hiding this comment.
The color "#ccc" represents a light gray color. It is often used as a neutral background color and I take this color is referenced from the "react-components/react-portal-compat" package.
…luentui into usr/asurse/remdepV9
In the earlier VR stories for HorizontalBarChart and VerticalBarChart, they used the charts "1. HorizontalBarChartWithAxis, 2. VerticalStackedBarChart, 3. GroupedVerticalBarChart." However, these charts have not yet been defined or created in ChartsV9. Therefore, we have removed this code.
v-asurse
force-pushed
the
usr/asurse/remdepV9
branch
from
61fc6f8
to
1cc2834
Compare
…ne chart. And fixed 2 Vertical bar chart test cases.
AtishayMsft
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
ChartsV9 is using some dependency from chartsV8 in there testcase files.
New Behavior
Removed chartsV8 dependency from chartsV9 testcase files.
Removed dep.: 1. resetIds, 2. DarkTheme, 3. DefaultPalette, 4. mergeStyles.
Replace the 'ThemeProvider' with "FluentProvider".