chore(web-components): refactor fluent-dialog and add new fluent-dialog-body component#31512
Merged
chrisdholt merged 20 commits intoJun 4, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 29, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eljefe223
reviewed
May 29, 2024
eljefe223
reviewed
May 29, 2024
eljefe223
reviewed
May 29, 2024
eljefe223
reviewed
May 29, 2024
chrisdholt
reviewed
May 29, 2024
Member
chrisdholt
left a comment
chrisdholt
left a comment
There was a problem hiding this comment.
This looks like a great improvement - a couple questions and comments to see if we can trim/simplify/align in a few places
eljefe223
reviewed
May 29, 2024
chrisdholt
reviewed
May 29, 2024
chrisdholt
approved these changes
May 30, 2024
janechu
reviewed
May 31, 2024
davatron5000
force-pushed
the
davatron5000/refactor-fluent-dialog
branch
from
2d11400 to
f20fe20
Compare
radium-v
reviewed
May 31, 2024
Contributor
radium-v
left a comment
radium-v
left a comment
There was a problem hiding this comment.
The reduction in class methods is incredible to see here, great work!
I'd love to see some more Playwright tests, as well as some duplication cleanup in the story files if that's possible.
chrisdholt
approved these changes
Jun 3, 2024
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
davatron5000
force-pushed
the
davatron5000/refactor-fluent-dialog
branch
from
c32edae to
d08c0b1
Compare
janechu
approved these changes
Jun 4, 2024
radium-v
approved these changes
Jun 4, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…og-body component (microsoft#31512) Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com> Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
<fluent-dialog>had a lot of duplicate functionality with nativeHTMLDialogElementNew Behavior
openattribute functionalitymodalTypeattribute totype<fluent-dialog-body>element to handle default content behavior<fluent-dialog>Related Issue(s)