Skip to content

Removed iconPosition from the Breadcrumb#28846

Merged
ValentinaKozlova merged 5 commits intomicrosoft:masterfrom
ValentinaKozlova:feat/breadcrumb-left-icon
Aug 15, 2023
Merged

Removed iconPosition from the Breadcrumb#28846
ValentinaKozlova merged 5 commits intomicrosoft:masterfrom
ValentinaKozlova:feat/breadcrumb-left-icon

Conversation

@ValentinaKozlova
Copy link
Contributor

After discussion with design team we can have only left icon in the Breadcrumb

Previous Behavior

It was possible to have only icon and iconPosition: 'after'

image
image
image

New Behavior

Only left icon is supported.

image
image
image

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023

📊 Bundle size report

🤖 This report was generated against 80a90fb61ed1e1a08cf6e897503a198dda97ed6c

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review August 14, 2023 13:03
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner August 14, 2023 13:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4478bab:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 80a90fb61ed1e1a08cf6e897503a198dda97ed6c (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@ValentinaKozlova ValentinaKozlova merged commit a3e1a60 into microsoft:master Aug 15, 2023
@ValentinaKozlova ValentinaKozlova deleted the feat/breadcrumb-left-icon branch August 15, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants