chore(web-components-v3): cherry-pick some changes to fix CI check#28240
Merged
TristanWatanabe merged 3 commits intomicrosoft:web-components-v3from Jun 23, 2023
Merged
Conversation
012d0c1 to
d8da954
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesUnable to find bundle size details for Baseline commit: ab307c4 Possible causes
Recommendations
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8d2512:
|
Hotell
approved these changes
Jun 19, 2023
micahgodbolt
approved these changes
Jun 20, 2023
Member
Author
|
@microsoft/teams-prg could i please get a review? :) |
khmakoto
approved these changes
Jun 20, 2023
ling1726
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
web-components-v3branch is outdated and failing certain checks in CI (particularly the bundle size checks and the ts-minbar check) which blocks PRs.Changes:
contentprop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes #27467