Datepicker onCalendarOpenStateChange prop#28136
Merged
jurokapsiar merged 6 commits intomicrosoft:masterfrom Jun 12, 2023
Merged
Datepicker onCalendarOpenStateChange prop#28136jurokapsiar merged 6 commits intomicrosoft:masterfrom
jurokapsiar merged 6 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 711a734d30fab93fd8359e2880329beacd237e2a |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatDuplicateMessagesPerf.default | 170 | 153 | 1.11:1 |
| TextAreaMinimalPerf.default | 305 | 287 | 1.06:1 |
| ReactionMinimalPerf.default | 217 | 207 | 1.05:1 |
| AttachmentMinimalPerf.default | 86 | 83 | 1.04:1 |
| BoxMinimalPerf.default | 205 | 197 | 1.04:1 |
| RadioGroupMinimalPerf.default | 267 | 257 | 1.04:1 |
| RefMinimalPerf.default | 111 | 107 | 1.04:1 |
| TreeMinimalPerf.default | 495 | 477 | 1.04:1 |
| HeaderSlotsPerf.default | 483 | 468 | 1.03:1 |
| InputMinimalPerf.default | 549 | 532 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 737 | 713 | 1.03:1 |
| LayoutMinimalPerf.default | 203 | 198 | 1.03:1 |
| ListMinimalPerf.default | 322 | 313 | 1.03:1 |
| VideoMinimalPerf.default | 445 | 434 | 1.03:1 |
| AttachmentSlotsPerf.default | 660 | 646 | 1.02:1 |
| ButtonMinimalPerf.default | 90 | 88 | 1.02:1 |
| CarouselMinimalPerf.default | 266 | 262 | 1.02:1 |
| CheckboxMinimalPerf.default | 1164 | 1143 | 1.02:1 |
| ListCommonPerf.default | 409 | 401 | 1.02:1 |
| RosterPerf.default | 1570 | 1542 | 1.02:1 |
| PopupMinimalPerf.default | 354 | 348 | 1.02:1 |
| AccordionMinimalPerf.default | 81 | 80 | 1.01:1 |
| AvatarMinimalPerf.default | 117 | 116 | 1.01:1 |
| ButtonSlotsPerf.default | 319 | 317 | 1.01:1 |
| DialogMinimalPerf.default | 458 | 453 | 1.01:1 |
| DividerMinimalPerf.default | 205 | 203 | 1.01:1 |
| DropdownMinimalPerf.default | 1409 | 1393 | 1.01:1 |
| EmbedMinimalPerf.default | 1759 | 1748 | 1.01:1 |
| FlexMinimalPerf.default | 155 | 153 | 1.01:1 |
| FormMinimalPerf.default | 225 | 223 | 1.01:1 |
| GridMinimalPerf.default | 190 | 188 | 1.01:1 |
| ProviderMergeThemesPerf.default | 677 | 668 | 1.01:1 |
| ToolbarMinimalPerf.default | 541 | 538 | 1.01:1 |
| TooltipMinimalPerf.default | 1276 | 1265 | 1.01:1 |
| DatepickerMinimalPerf.default | 3624 | 3608 | 1:1 |
| HeaderMinimalPerf.default | 212 | 212 | 1:1 |
| LabelMinimalPerf.default | 224 | 225 | 1:1 |
| ListNestedPerf.default | 315 | 316 | 1:1 |
| MenuButtonMinimalPerf.default | 953 | 953 | 1:1 |
| ProviderMinimalPerf.default | 207 | 207 | 1:1 |
| SplitButtonMinimalPerf.default | 2236 | 2238 | 1:1 |
| TableManyItemsPerf.default | 1115 | 1116 | 1:1 |
| ButtonOverridesMissPerf.default | 627 | 633 | 0.99:1 |
| DropdownManyItemsPerf.default | 393 | 396 | 0.99:1 |
| LoaderMinimalPerf.default | 190 | 192 | 0.99:1 |
| MenuMinimalPerf.default | 494 | 499 | 0.99:1 |
| CustomToolbarPrototype.default | 1444 | 1453 | 0.99:1 |
| ListWith60ListItems.default | 369 | 378 | 0.98:1 |
| SkeletonMinimalPerf.default | 193 | 197 | 0.98:1 |
| StatusMinimalPerf.default | 397 | 405 | 0.98:1 |
| TableMinimalPerf.default | 236 | 242 | 0.98:1 |
| TextMinimalPerf.default | 198 | 202 | 0.98:1 |
| AnimationMinimalPerf.default | 291 | 301 | 0.97:1 |
| SliderMinimalPerf.default | 684 | 705 | 0.97:1 |
| CardMinimalPerf.default | 307 | 320 | 0.96:1 |
| ImageMinimalPerf.default | 216 | 224 | 0.96:1 |
| SegmentMinimalPerf.default | 192 | 199 | 0.96:1 |
| IconMinimalPerf.default | 384 | 399 | 0.96:1 |
| TreeWith60ListItems.default | 87 | 91 | 0.96:1 |
| AlertMinimalPerf.default | 151 | 161 | 0.94:1 |
| ChatWithPopoverPerf.default | 189 | 202 | 0.94:1 |
| ChatMinimalPerf.default | 415 | 444 | 0.93:1 |
| PortalMinimalPerf.default | 83 | 90 | 0.92:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6a230b:
|
ling1726
reviewed
Jun 5, 2023
packages/fluentui/react-northstar/src/components/Datepicker/Datepicker.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
June 8, 2023 21:21
ling1726
reviewed
Jun 9, 2023
packages/fluentui/react-northstar/src/components/Datepicker/Datepicker.tsx
Show resolved
Hide resolved
ling1726
approved these changes
Jun 9, 2023
fabricteam
reviewed
Jun 11, 2023
| @@ -18,6 +18,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 1 screenshots
✅ There was 0 screenshots added, 1 screenshots removed, 1259 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Chat.Chat Example Details Teams High Contrast.chromium.png | 0 | Removed |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 13, 2023
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
https://fluentsite.z22.web.core.windows.net/0.66.2/components/datepicker/definition?showCode=false&showRtl=false&showTransparent=false&showVariables=false#types-open
Datepicker only had
calendarOpenStateprop but the change callback prop was missingNew Behavior
onCalendarOpenStateChangeis called when the state is changed internally.