Export selection types from combobox by micahgodbolt · Pull Request #28054 · microsoft/fluentui

micahgodbolt · 2023-05-30T19:27:55Z

fixes #27996

size-auditor · 2023-05-30T19:38:50Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4da116adb29b9fb5b0a7f93d71cc52011591d64f (build)

fabricteam · 2023-05-30T19:39:13Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	597	579	5000
Button	mount	305	294	5000
Field	mount	1034	1039	5000
FluentProvider	mount	658	647	5000
FluentProviderWithTheme	mount	80	91	10
FluentProviderWithTheme	virtual-rerender	85	83	10
FluentProviderWithTheme	virtual-rerender-with-unmount	84	83	10
InfoButton	mount	20	17	5000
MakeStyles	mount	882	849	50000
Persona	mount	1642	1589	5000
SpinButton	mount	1260	1200	5000

codesandbox-ci · 2023-05-30T19:39:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f12d32e:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-05-30T19:40:40Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-combobox` Combobox (including child components)	`87.735 kB` `28.243 kB`
`react-combobox` Dropdown (including child components)	`86.074 kB` `27.848 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`64.899 kB` `17.91 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`206.425 kB` `57.914 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.132 kB` `11.954 kB`
`react-portal-compat` PortalCompatProvider	`6.473 kB` `2.196 kB`

_{🤖 This report was generated against 4da116adb29b9fb5b0a7f93d71cc52011591d64f}

fabricteam · 2023-05-30T19:51:56Z

🕵 fluentuiv9 No visual regressions between this PR and main

msft-fluent-ui-bot · 2023-05-31T07:41:15Z

🎉@fluentui/babel-preset-global-context@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:18Z

🎉@fluentui/react-aria@v9.3.22 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:24Z

🎉@fluentui/react-context-selector@v9.1.22 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:27Z

🎉@fluentui/react-data-grid-react-window@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:33Z

🎉@fluentui/react-jsx-runtime@v9.0.0-alpha.6 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:36Z

🎉@fluentui/react-persona@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:45Z

🎉@fluentui/react-portal-compat@v9.0.60 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:48Z

🎉@fluentui/react-portal@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:41:57Z

🎉@fluentui/react-progress@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:42:03Z

🎉@fluentui/react-provider@v9.7.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:42:06Z

🎉@fluentui/react-radio@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:42:12Z

🎉@fluentui/react-select@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:42:15Z

🎉@fluentui/react-skeleton@v9.0.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:42:21Z

🎉@fluentui/react-slider@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:03Z

🎉@fluentui/react-toolbar@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:06Z

🎉@fluentui/react-tooltip@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:12Z

🎉@fluentui/react-tree@v9.0.0-beta.18 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:21Z

🎉@fluentui/react-virtualizer@v9.0.0-alpha.22 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:24Z

🎉@fluentui/global-context@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:27Z

🎉@fluentui/react-accordion@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:33Z

🎉@fluentui/react-alert@v9.0.0-beta.51 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:42Z

🎉@fluentui/react-avatar@v9.5.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:45Z

🎉@fluentui/react-badge@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:51Z

🎉@fluentui/react-button@v9.3.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:43:57Z

🎉@fluentui/react-card@v9.0.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:03Z

🎉@fluentui/react-checkbox@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:18Z

🎉@fluentui/react-table@v9.3.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:39Z

🎉@fluentui/react-datepicker-compat@v0.1.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:45Z

🎉@fluentui/react-dialog@v9.5.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:48Z

🎉@fluentui/react-divider@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:44:54Z

🎉@fluentui/react-drawer@v9.0.0-beta.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:00Z

🎉@fluentui/react-field@v9.1.6 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:03Z

🎉@fluentui/react-image@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:09Z

🎉@fluentui/react-infobutton@v9.0.0-beta.34 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:15Z

🎉@fluentui/react-input@v9.4.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:18Z

🎉@fluentui/react-label@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:24Z

🎉@fluentui/react-link@v9.0.42 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:30Z

🎉@fluentui/react-menu@v9.7.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:36Z

🎉@fluentui/react-migration-v0-v9@v9.0.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:39Z

🎉@fluentui/react-migration-v8-v9@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:45:45Z

🎉@fluentui/react-overflow@v9.0.19 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:46:30Z

🎉@fluentui/react-combobox@v9.4.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2023-05-31T07:50:42Z

🎉@fluentui/react-components@v9.21.0 has been released which incorporates this pull request.:tada:

Handy links:

* master: Added truncation and tooltips to the Breadcrumb (microsoft#27859) applying package updates applying package updates Export selection types from combobox (microsoft#28054) fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053) Updated poster for new stable components (microsoft#28051) Griffel/bump to 1.5.7 (microsoft#27925) feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380) chore: Add positioning test for scroll jumps (microsoft#28043) chore: migrate to TS 4.5 (microsoft#27936) Fix toolbar divider styles (microsoft#28044) fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966) feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)

micahgodbolt added 2 commits May 30, 2023 12:20

export selection types from combobox

982fc89

change and api update

f12d32e

micahgodbolt requested review from a team and smhigley as code owners May 30, 2023 19:27

msft-fluent-ui-bot assigned micahgodbolt May 30, 2023

msft-fluent-ui-bot added the Component: Combobox label May 30, 2023

github-actions bot added this to the May Project Cycle Q2 2023 milestone May 30, 2023

smhigley approved these changes May 30, 2023

View reviewed changes

micahgodbolt merged commit 17ca96c into microsoft:master May 30, 2023

micahgodbolt deleted the selection-type-export branch May 30, 2023 20:52

msft-fluent-ui-bot mentioned this pull request May 31, 2023

Fluent v9: Types SelectionEvents and OptionOnSelectData are not surfaced to the user #27996

Closed

Conversation

micahgodbolt commented May 30, 2023

Uh oh!

size-auditor bot commented May 30, 2023

Asset size changes

Uh oh!

fabricteam commented May 30, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented May 30, 2023

Uh oh!

fabricteam commented May 30, 2023

📊 Bundle size report

Uh oh!

fabricteam commented May 30, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Uh oh!

msft-fluent-ui-bot commented May 31, 2023

Perf Analysis (`@fluentui/react-components`)