Skip to content

fix: make the selected styles have higher priority#27985

Merged
marcosmoura merged 2 commits intomicrosoft:masterfrom
marcosmoura:fix/make-selected-styles-with-higher-specificity
May 25, 2023
Merged

fix: make the selected styles have higher priority#27985
marcosmoura merged 2 commits intomicrosoft:masterfrom
marcosmoura:fix/make-selected-styles-with-higher-specificity

Conversation

@marcosmoura
Copy link
Contributor

See title

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 595 566 5000
Button mount 289 294 5000
Field mount 1010 1020 5000
FluentProvider mount 652 647 5000
FluentProviderWithTheme mount 84 75 10
FluentProviderWithTheme virtual-rerender 58 67 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 65 10
InfoButton mount 7 20 5000
MakeStyles mount 848 827 50000
Persona mount 1591 1581 5000
SpinButton mount 1263 1202 5000

@size-auditor
Copy link

size-auditor bot commented May 24, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8ec648d4060906a32bad46a16e0eae13a7aa5959 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
88.428 kB
25.004 kB
react-card
Card
83.363 kB
23.556 kB
react-card
CardFooter
9.158 kB
3.844 kB
react-card
CardHeader
11.048 kB
4.538 kB
react-card
CardPreview
9.963 kB
4.192 kB
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
205.944 kB
57.706 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
🤖 This report was generated against 8ec648d4060906a32bad46a16e0eae13a7aa5959

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09e3cb6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@marcosmoura marcosmoura merged commit 2170172 into microsoft:master May 25, 2023
@marcosmoura marcosmoura deleted the fix/make-selected-styles-with-higher-specificity branch May 25, 2023 12:25
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-card@v9.0.14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-components@v9.21.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants