Skip to content

Table: visualize column that is being resized by keyboard#27953

Merged
george-cz merged 8 commits intomicrosoft:masterfrom
george-cz:table-keyboard-resize-style
May 29, 2023
Merged

Table: visualize column that is being resized by keyboard#27953
george-cz merged 8 commits intomicrosoft:masterfrom
george-cz:table-keyboard-resize-style

Conversation

@george-cz
Copy link
Contributor

@george-cz george-cz commented May 23, 2023

This PR adds visual information that a column is being resized by keyboard.
image

Fixes #27665

@fabricteam
Copy link
Collaborator

fabricteam commented May 23, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 13 14 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 574 583 5000
Button mount 290 305 5000
Field mount 1035 1000 5000
FluentProvider mount 666 661 5000
FluentProviderWithTheme mount 81 78 10
FluentProviderWithTheme virtual-rerender 72 65 10
FluentProviderWithTheme virtual-rerender-with-unmount 81 74 10
InfoButton mount 13 14 5000 Possible regression
MakeStyles mount 875 872 50000
Persona mount 1603 1603 5000
SpinButton mount 1286 1290 5000

@size-auditor
Copy link

size-auditor bot commented May 23, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d145902686da811aeb90e506b829044e1fb3cf90 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0dc50b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 23, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-table
DataGrid
149.871 kB
41.174 kB
150.615 kB
41.4 kB
744 B
226 B
react-table
Table (Primitives only)
44.348 kB
12.347 kB
45.09 kB
12.527 kB
742 B
180 B
react-table
Table as DataGrid
132.427 kB
33.748 kB
133.169 kB
33.926 kB
742 B
178 B
react-table
Table (Selection only)
78.201 kB
19.143 kB
78.943 kB
19.333 kB
742 B
190 B
react-table
Table (Sort only)
77.531 kB
18.953 kB
78.273 kB
19.144 kB
742 B
191 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.252 kB
57.786 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
🤖 This report was generated against d145902686da811aeb90e506b829044e1fb3cf90

@george-cz george-cz force-pushed the table-keyboard-resize-style branch from bb93f4b to c546c59 Compare May 25, 2023 10:14
@george-cz george-cz requested a review from a team as a code owner May 26, 2023 09:03
@george-cz george-cz changed the title Update table stories to visualize column thats being resized Table: visualize column that is being resized by keyboard May 26, 2023
@george-cz george-cz enabled auto-merge (squash) May 26, 2023 11:29
@george-cz george-cz merged commit f376f28 into microsoft:master May 29, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-table@v9.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-components@v9.21.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table column resizing has no indicator when using keyboard

5 participants