Table: visualize column that is being resized by keyboard#27953
Merged
george-cz merged 8 commits intomicrosoft:masterfrom May 29, 2023
Merged
Table: visualize column that is being resized by keyboard#27953george-cz merged 8 commits intomicrosoft:masterfrom
george-cz merged 8 commits intomicrosoft:masterfrom
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 13 | 14 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 574 | 583 | 5000 | |
| Button | mount | 290 | 305 | 5000 | |
| Field | mount | 1035 | 1000 | 5000 | |
| FluentProvider | mount | 666 | 661 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 72 | 65 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 74 | 10 | |
| InfoButton | mount | 13 | 14 | 5000 | Possible regression |
| MakeStyles | mount | 875 | 872 | 50000 | |
| Persona | mount | 1603 | 1603 | 5000 | |
| SpinButton | mount | 1286 | 1290 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d145902686da811aeb90e506b829044e1fb3cf90 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0dc50b:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
george-cz
commented
May 23, 2023
packages/react-components/react-table/stories/Table/ResizableColumnsUncontrolled.stories.tsx
Show resolved
Hide resolved
george-cz
commented
May 23, 2023
packages/react-components/react-table/stories/DataGrid/KeyboardColumnResizing.stories.tsx
Show resolved
Hide resolved
ling1726
reviewed
May 24, 2023
packages/react-components/react-table/stories/DataGrid/KeyboardColumnResizing.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 24, 2023
packages/react-components/react-table/stories/DataGrid/KeyboardColumnResizing.stories.tsx
Outdated
Show resolved
Hide resolved
bb93f4b to
c546c59
Compare
ling1726
reviewed
May 25, 2023
packages/react-components/react-table/stories/DataGrid/KeyboardColumnResizing.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 25, 2023
ling1726
reviewed
May 25, 2023
...act-components/react-table/src/components/TableHeaderCell/useTableHeaderCellStyles.styles.ts
Show resolved
Hide resolved
ling1726
approved these changes
May 25, 2023
fabricteam
reviewed
May 26, 2023
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds visual information that a column is being resized by keyboard.

Fixes #27665