feat: Implement support for multiple toaster on a page#27831
Merged
ling1726 merged 3 commits intomicrosoft:masterfrom May 15, 2023
Merged
feat: Implement support for multiple toaster on a page#27831ling1726 merged 3 commits intomicrosoft:masterfrom
ling1726 merged 3 commits intomicrosoft:masterfrom
Conversation
Adds the `toasterId` prop to all Toaster components and controllers. If a Toaster has the `toasterId` prop set, then it will ignore any toast events except those with its id.
ling1726
commented
May 12, 2023
ling1726
commented
May 12, 2023
packages/react-components/react-toast/stories/Toast/CustomTimeout.stories.tsx
Show resolved
Hide resolved
Collaborator
📊 Bundle size report🤖 This report was generated against adb50a1f3d4d2843943bc0917979050d7925792c |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f44600a9b36abdd6aed4aaa8e44afdf049f8870f (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5cdb457:
|
bsunderhus
approved these changes
May 15, 2023
| return ( | ||
| <> | ||
| <Toaster /> | ||
| <Toaster toasterId={toasterId} /> |
Member
There was a problem hiding this comment.
Is usage of toasterId mandatory? If no, why all examples were updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
toasterIdprop to all Toaster components and controllers. If a Toaster has thetoasterIdprop set, then it will ignore any toast events except those with its id.This change required splitting up the dismissing functionalities into:
Addresses #27827