Skip to content

chore(react-skeleton): Release react-skeleton to stable#27767

Merged
tomi-msft merged 7 commits intomicrosoft:masterfrom
tomi-msft:react-skeleton-stable
May 8, 2023
Merged

chore(react-skeleton): Release react-skeleton to stable#27767
tomi-msft merged 7 commits intomicrosoft:masterfrom
tomi-msft:react-skeleton-stable

Conversation

@tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented May 4, 2023

This PR releases react-skeleton to stable.

FIxes #25275

@tomi-msft tomi-msft requested review from a team as code owners May 4, 2023 21:43
@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 4, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented May 4, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 33 23 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 953 945 5000
Button mount 495 502 5000
Field mount 1731 1736 5000
FluentProvider mount 1109 1149 5000
FluentProviderWithTheme mount 157 149 10
FluentProviderWithTheme virtual-rerender 126 124 10
FluentProviderWithTheme virtual-rerender-with-unmount 131 135 10
InfoButton mount 33 23 5000 Possible regression
MakeStyles mount 1362 1377 50000
Persona mount 2664 2617 5000
SpinButton mount 2028 2144 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 4, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 203.885 kB
57.081 kB
react-components
react-components: FluentProvider & webLightTheme		 36.086 kB
11.9 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.186 kB
🤖 This report was generated against 347e2f68a22630b6de882ef032e5a42695b64774

@size-auditor
Copy link

size-auditor bot commented May 4, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 347e2f68a22630b6de882ef032e5a42695b64774 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 4, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af1334e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

khmakoto
khmakoto reviewed May 8, 2023
View reviewed changes
@tomi-msft @khmakoto
Apply suggestions from code review
af1334e 
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
@tomi-msft
Copy link
Contributor Author

tomi-msft commented May 8, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 8, 2023

Azure Pipelines successfully started running 4 pipeline(s).

@tomi-msft tomi-msft merged commit c02b44a into microsoft:master May 8, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-header
a6a3377 
* master:
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'feat/drawer-header' into feat/split-drawer
8c3385f 
* feat/drawer-header:
  fix: add changefiles
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-footer
ab506e5 
* master: (29 commits)
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
  applying package updates
  fix: do not use outlineStyle: none in createCustomFocusIndicatorStyle (microsoft#26089)
  fix: Scale pulse animation with percentages and flip wave animation's direction (microsoft#27654)
  Publish dist folder that got removed due to node 16 upgrade (microsoft#27764)
  fix(scripts-update-release-notes): properly handle git for-each-ref cmd call to not fail release notes update (microsoft#27757)
  ...
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented May 15, 2023

🎉@fluentui/react-skeleton@v9.0.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request May 15, 2023
Closed
22 tasks
This was referenced May 23, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

Assignees

@bsunderhus bsunderhus

Labels

Area: Components Component: Shimmer

Projects

None yet

Milestone

May Project Cycle Q2 2023

Development

Successfully merging this pull request may close these issues.

Skeleton

5 participants

@tomi-msft @fabricteam @msft-fluent-ui-bot @khmakoto @bsunderhus