Skip to content

Added BreadcrumbLink component#27471

Merged
ValentinaKozlova merged 3 commits intomicrosoft:masterfrom
ValentinaKozlova:feat/breadcrumb-link
Apr 14, 2023
Merged

Added BreadcrumbLink component#27471
ValentinaKozlova merged 3 commits intomicrosoft:masterfrom
ValentinaKozlova:feat/breadcrumb-link

Conversation

@ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Apr 6, 2023

Non-clickable items shouldn't have icons. The icon will be part of BreadcrumbButton and BreadcrumbLink.
I updated the spec in #27428

New Behavior

image

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 6, 2023

📊 Bundle size report

🤖 This report was generated against ea04a996fe1a9171f3cd4d0dd531fe06431edec0

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb23e95:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 6, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c156e7682a89d7766bed3c0b9f231dc2e0a2058b (build)

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review April 11, 2023 12:25
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner April 11, 2023 12:25
@marcosmoura marcosmoura self-requested a review April 12, 2023 12:11
@ValentinaKozlova ValentinaKozlova merged commit 25f87de into microsoft:master Apr 14, 2023
@ValentinaKozlova ValentinaKozlova deleted the feat/breadcrumb-link branch April 14, 2023 12:13
@ValentinaKozlova ValentinaKozlova mentioned this pull request Apr 17, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants