chore(react-datepicker-compat): Add cypress and unit tests for DatePicker#27209
Merged
sopranopillow merged 7 commits intomicrosoft:masterfrom Mar 16, 2023
Merged
Conversation
…eact-datepicker-compat/tests-datepicker
sopranopillow
added
Fluent UI react-components (v9)
Component: DatePickerCompat
sopranopillow
commented
Mar 15, 2023
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.types.ts
Show resolved
Hide resolved
Collaborator
📊 Bundle size report🤖 This report was generated against be936b6edefb8d319b6693eb1f36230b716377da |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: be936b6edefb8d319b6693eb1f36230b716377da (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 22b43fc:
|
khmakoto
reviewed
Mar 15, 2023
.../react-components/react-datepicker-compat/src/components/CalendarDayGrid/CalendarDayGrid.tsx
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.cy.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.cy.tsx
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Mar 15, 2023
Contributor
Hotell
left a comment
Hotell
left a comment
There was a problem hiding this comment.
you need to add new tsconfig.cy.json and update tsconfig.lib.json includes and tsconfig.json references.
I thought this is covered by yarn nx workspace-generator migrate-converged-pkg @fluentui/react-datepicker-compat, which seems to not be the case. TODO - report bug ?
2 tasks
Contributor
Author
khmakoto
approved these changes
Mar 15, 2023
TristanWatanabe
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds cypress tests and unit tests for DatePicker. A next step will be to add vr-tests which is tracked by another issue: #27207.
This PR also adds the basic config for cypress tests for
react-datepicker-compat.Related Issue(s)