Skip to content

feat: Adding calls to custom style hooks derived from context in react-tabs components#27077

Merged
GeoffCoxMSFT merged 4 commits intomicrosoft:masterfrom
GeoffCoxMSFT:custom-style-tabs
Mar 7, 2023
Merged

feat: Adding calls to custom style hooks derived from context in react-tabs components#27077
GeoffCoxMSFT merged 4 commits intomicrosoft:masterfrom
GeoffCoxMSFT:custom-style-tabs

Conversation

@GeoffCoxMSFT
Copy link
Member

Changes

  • Updated components to call custom style hook

Issues

@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team as a code owner March 4, 2023 18:23
@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Mar 4, 2023
@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 4, 2023
@size-auditor
Copy link

size-auditor bot commented Mar 4, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 606845129c288af984f0f43dc44c54f9093c39eb (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.061 kB
18.105 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.05 kB
57.069 kB
react-components
react-components: FluentProvider & webLightTheme
37.891 kB
12.039 kB
react-portal-compat
PortalCompatProvider
6.324 kB
2.129 kB
🤖 This report was generated against 606845129c288af984f0f43dc44c54f9093c39eb

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53c2b62:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1320 1343 5000
Button mount 947 947 5000
Field mount 2057 2037 5000
FluentProvider mount 1647 1633 5000
FluentProviderWithTheme mount 635 636 10
FluentProviderWithTheme virtual-rerender 594 601 10
FluentProviderWithTheme virtual-rerender-with-unmount 639 635 10
InfoButton mount 565 566 5000
MakeStyles mount 1891 1885 50000
Persona mount 3071 3045 5000
SpinButton mount 2481 2416 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 4, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) March 5, 2023 21:11
@khmakoto khmakoto changed the title Custom style react-tabs feat: Adding calls to custom style hooks derived from context in react-tabs components Mar 6, 2023
GeoffCoxMSFT and others added 2 commits March 7, 2023 11:18
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants