Skip to content

Component testing - Donut chart#27033

Merged
srmukher merged 15 commits intomicrosoft:masterfrom
srmukher:users/srmukher/CompTestDonut
May 2, 2023
Merged

Component testing - Donut chart#27033
srmukher merged 15 commits intomicrosoft:masterfrom
srmukher:users/srmukher/CompTestDonut

Conversation

@srmukher
Copy link
Contributor

@srmukher srmukher commented Mar 2, 2023

Added component tests for donut chart. Increasing the code coverage for donut chart to 96% (functions covered) as follows:

image

The corresponding test plan is also attached as an MD file.

@srmukher srmukher requested review from a team as code owners March 2, 2023 10:57
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 2, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against ee7173e0feabf921a7a8a7cbbb0e63afa4f83f84

@size-auditor
Copy link

size-auditor bot commented Mar 2, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ee7173e0feabf921a7a8a7cbbb0e63afa4f83f84 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04d58f2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@tudorpopams tudorpopams requested a review from Hotell March 2, 2023 13:13
Hotell
Hotell reviewed Mar 3, 2023
View reviewed changes
@Hotell Hotell removed their assignment Mar 3, 2023
@srmukher srmukher force-pushed the users/srmukher/CompTestDonut branch from c99cd7c to 1e77d96 Compare March 30, 2023 05:24
@srmukher srmukher force-pushed the users/srmukher/CompTestDonut branch from 39e958f to 097cd86 Compare April 17, 2023 10:56
AtishayMsft
AtishayMsft reviewed Apr 18, 2023
View reviewed changes
@srmukher srmukher force-pushed the users/srmukher/CompTestDonut branch from 097cd86 to 9fa22d9 Compare April 19, 2023 07:17
@srmukher srmukher force-pushed the users/srmukher/CompTestDonut branch from 9fa22d9 to 11e91c2 Compare April 19, 2023 07:20
@srmukher srmukher merged commit 5349c8c into microsoft:master May 2, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 2, 2023
@marcosmoura
Merge branch 'feat/drawer-components' into feat/drawer-footer
5a4a3d1 
* feat/drawer-components: (120 commits)
  fix: add missing change file
  Component testing - Donut chart (microsoft#27033)
  fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741)
  chore: add .swcrc to .npmignore (generator) (microsoft#27739)
  docs: update API
  Autogenerate react-toast package (microsoft#27730)
  applying package updates
  fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736)
  Add DraggableZone into export map (microsoft#27569)
  Add export for FolderCover.scss (microsoft#27507)
  applying package updates
  Add filetype icon for Microsoft Designer (microsoft#27724)
  ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729)
  fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728)
  Added partition for controlled overflow menu (microsoft#27520)
  Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186)
  Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346)
  chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605)
  chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710)
  chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

@AtishayMsft AtishayMsft AtishayMsft approved these changes

Assignees

No one assigned

Labels

Package: charting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srmukher @fabricteam @Hotell @AtishayMsft @msft-fluent-ui-bot