Skip to content

feat(react-recipes): Adding MediaObject recipe and Example template #26594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2023
Merged

feat(react-recipes): Adding MediaObject recipe and Example template #26594

merged 4 commits into from
Mar 3, 2023

Conversation

@sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Feb 1, 2023

This PR adds the following:

  • MediaObject recipe.
  • Example template similar to the v9-docsite's examples.

Related Issue(s)

@sopranopillow sopranopillow requested a review from a team as a code owner February 1, 2023 19:51
@sopranopillow sopranopillow self-assigned this Feb 1, 2023
@sopranopillow sopranopillow requested review from a team as code owners February 1, 2023 19:51
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 1, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 306fe5e1e38b36e84daf48a23817704416be2bb4

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a2e375:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 1, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 306fe5e1e38b36e84daf48a23817704416be2bb4 (build)

spmonahan
spmonahan reviewed Feb 1, 2023
View reviewed changes
@tudorpopams tudorpopams requested a review from Hotell February 2, 2023 13:15
@sopranopillow
Copy link
Contributor Author

sopranopillow commented Feb 6, 2023

@Hotell I realize that maybe it's not convenient to have @microsoft/fluentui-react-build as codeowner, I can change it for @microsoft/fluentui-react if prefered. What do you think about it?

@Hotell
Copy link
Contributor

Hotell commented Mar 3, 2023

@Hotell I realize that maybe it's not convenient to have @microsoft/fluentui-react-build as codeowner, I can change it for @microsoft/fluentui-react if prefered. What do you think about it?

sounds good! ty

Hotell
Hotell approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to update your branch before merging ( we migrated to prettier 2.8 )

and run
yarn
yarn format --all

submit any changes

merge

ty

@sopranopillow sopranopillow enabled auto-merge (squash) March 3, 2023 18:16
@sopranopillow sopranopillow merged commit a2cb1db into microsoft:master Mar 3, 2023
@sopranopillow sopranopillow deleted the recipes/media-object branch March 3, 2023 18:31
@sopranopillow sopranopillow mentioned this pull request Mar 3, 2023
Merged
@sopranopillow sopranopillow mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

@spmonahan spmonahan Awaiting requested review from spmonahan

Assignees

@sopranopillow sopranopillow

Labels

Area: Recipes Fluent UI react-components (v9)

Projects

None yet

Milestone

February Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

Recipes: Write Media Object recipe

4 participants

@sopranopillow @fabricteam @Hotell @spmonahan