chore(scripts): remove unused logic from tsc,api-extractor used for partial migration by Hotell · Pull Request #25678 · microsoft/fluentui

Hotell · 2022-11-15T16:35:56Z

Pre-requirements:

feat(scripts): remove @internal stripping and enable no deps build needed for api generation #25575

Current Behavior

New Behavior

Related Issue(s)

Follows #25575

…artial migration

fabricteam · 2022-11-15T16:42:03Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`86.996 kB` `21.732 kB`
`react-avatar` Avatar	`51.181 kB` `14.31 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`65.759 kB` `18.408 kB`
`react-badge` Badge	`22.656 kB` `7.225 kB`
`react-badge` CounterBadge	`23.546 kB` `7.508 kB`
`react-badge` PresenceBadge	`24.106 kB` `7.087 kB`
`react-button` Button	`36.86 kB` `9.913 kB`
`react-button` CompoundButton	`43.885 kB` `11.131 kB`
`react-button` MenuButton	`41.537 kB` `11.187 kB`
`react-button` SplitButton	`48.983 kB` `12.588 kB`
`react-button` ToggleButton	`52.685 kB` `11.415 kB`
`react-card` Card - All	`71.873 kB` `20.936 kB`
`react-card` Card	`67.651 kB` `19.892 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`9.792 kB` `3.995 kB`
`react-card` CardPreview	`8.718 kB` `3.674 kB`
`react-combobox` Combobox (including child components)	`78.086 kB` `24.988 kB`
`react-combobox` Dropdown (including child components)	`77.373 kB` `24.891 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.951 kB` `17.675 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`190.427 kB` `53.087 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.456 kB` `11.029 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`117.938 kB` `35.399 kB`
`react-input` Input	`24.122 kB` `7.889 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.61 kB` `36.287 kB`
`react-menu` Menu (including selectable components)	`120.679 kB` `36.82 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`56.299 kB` `15.708 kB`
`react-popover` Popover	`103.682 kB` `31.867 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.536 kB` `5.11 kB`
`react-provider` FluentProvider	`15.817 kB` `5.905 kB`
`react-radio` Radio	`36.446 kB` `12.123 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.438 kB` `8.018 kB`
`react-slider` Slider	`32.118 kB` `10.192 kB`
`react-spinbutton` SpinButton	`44.43 kB` `12.812 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.453 kB` `10.581 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.697 kB` `8.328 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 131d20e15d6c59dce2dcbbd8794b5ee75701a670}

Hotell · 2022-11-15T16:48:41Z

scripts/just.config.ts

    return series(
      'ts:compile',
-      condition('copy-compiled', () => isConvergedPackage({ projectType: 'library' })),
+      'copy-compiled',


build pipeline is now driven by ts-config as the main source of truth which enables usage cross version (v8,9) without need of creating config discrepancies

fabricteam · 2022-11-15T16:55:50Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1664	1719	5000
Button	mount	1153	1205	5000
FluentProvider	mount	1976	1983	5000
FluentProviderWithTheme	mount	733	742	10
FluentProviderWithTheme	virtual-rerender	676	666	10
FluentProviderWithTheme	virtual-rerender-with-unmount	725	725	10
MakeStyles	mount	2289	2343	50000
SpinButton	mount	3265	3285	5000

size-auditor · 2022-11-15T16:58:11Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 131d20e15d6c59dce2dcbbd8794b5ee75701a670 (build)

fabricteam · 2022-11-15T16:58:33Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AttachmentMinimalPerf.default	119	123	0.97:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	144	132	1.09:1
AttachmentSlotsPerf.default	908	859	1.06:1
AccordionMinimalPerf.default	134	128	1.05:1
AvatarMinimalPerf.default	171	163	1.05:1
TreeWith60ListItems.default	137	130	1.05:1
SegmentMinimalPerf.default	312	299	1.04:1
AlertMinimalPerf.default	222	215	1.03:1
FlexMinimalPerf.default	264	256	1.03:1
PortalMinimalPerf.default	141	137	1.03:1
CarouselMinimalPerf.default	366	360	1.02:1
ChatMinimalPerf.default	644	631	1.02:1
CheckboxMinimalPerf.default	1544	1511	1.02:1
GridMinimalPerf.default	303	298	1.02:1
RosterPerf.default	1736	1702	1.02:1
StatusMinimalPerf.default	617	603	1.02:1
TextMinimalPerf.default	304	297	1.02:1
ButtonOverridesMissPerf.default	1018	1006	1.01:1
CardMinimalPerf.default	472	466	1.01:1
DialogMinimalPerf.default	690	683	1.01:1
DividerMinimalPerf.default	316	312	1.01:1
LabelMinimalPerf.default	334	332	1.01:1
LayoutMinimalPerf.default	312	310	1.01:1
ListNestedPerf.default	469	464	1.01:1
RefMinimalPerf.default	188	186	1.01:1
SliderMinimalPerf.default	1246	1236	1.01:1
SplitButtonMinimalPerf.default	3285	3253	1.01:1
CustomToolbarPrototype.default	2168	2139	1.01:1
AnimationMinimalPerf.default	464	466	1:1
BoxMinimalPerf.default	296	297	1:1
DatepickerMinimalPerf.default	4770	4755	1:1
DropdownManyItemsPerf.default	541	539	1:1
DropdownMinimalPerf.default	2175	2170	1:1
EmbedMinimalPerf.default	2641	2630	1:1
HeaderMinimalPerf.default	319	319	1:1
LoaderMinimalPerf.default	258	257	1:1
MenuMinimalPerf.default	728	729	1:1
MenuButtonMinimalPerf.default	1360	1355	1:1
ReactionMinimalPerf.default	329	328	1:1
TableManyItemsPerf.default	1572	1579	1:1
TableMinimalPerf.default	354	355	1:1
TextAreaMinimalPerf.default	419	418	1:1
ToolbarMinimalPerf.default	795	795	1:1
HeaderSlotsPerf.default	672	677	0.99:1
InputMinimalPerf.default	850	857	0.99:1
ItemLayoutMinimalPerf.default	958	968	0.99:1
ProviderMergeThemesPerf.default	980	990	0.99:1
RadioGroupMinimalPerf.default	390	394	0.99:1
IconMinimalPerf.default	570	576	0.99:1
TreeMinimalPerf.default	691	697	0.99:1
VideoMinimalPerf.default	625	630	0.99:1
ChatWithPopoverPerf.default	288	293	0.98:1
ListMinimalPerf.default	454	462	0.98:1
ButtonSlotsPerf.default	419	434	0.97:1
ChatDuplicateMessagesPerf.default	208	215	0.97:1
ListCommonPerf.default	504	517	0.97:1
PopupMinimalPerf.default	556	576	0.97:1
ProviderMinimalPerf.default	310	318	0.97:1
TooltipMinimalPerf.default	1872	1922	0.97:1
ImageMinimalPerf.default	335	351	0.95:1
ListWith60ListItems.default	472	498	0.95:1
SkeletonMinimalPerf.default	298	314	0.95:1
FormMinimalPerf.default	329	354	0.93:1

codesandbox-ci · 2022-11-15T17:00:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 675d36c:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-15T17:07:38Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1196	1204	5000
Breadcrumb	mount	2835	2763	1000
Checkbox	mount	2627	2622	5000
CheckboxBase	mount	2380	2375	5000
ChoiceGroup	mount	4286	4313	5000
ComboBox	mount	1192	1172	1000
CommandBar	mount	9335	9297	1000
ContextualMenu	mount	10416	10328	1000
DefaultButton	mount	1356	1360	5000
DetailsRow	mount	3389	3371	5000
DetailsRowFast	mount	3358	3361	5000
DetailsRowNoStyles	mount	3200	3203	5000
Dialog	mount	3003	2946	1000
DocumentCardTitle	mount	588	586	1000
Dropdown	mount	3145	3162	5000
FocusTrapZone	mount	1994	1944	5000
FocusZone	mount	1892	1892	5000
GroupedList	mount	1860	2080	2
GroupedList	virtual-rerender	1100	1108	2
GroupedList	virtual-rerender-with-unmount	1629	1651	2
GroupedListV2	mount	568	574	2
GroupedListV2	virtual-rerender	541	557	2
GroupedListV2	virtual-rerender-with-unmount	569	579	2
IconButton	mount	1777	1780	5000
Label	mount	765	752	5000
Layer	mount	4216	4146	5000
Link	mount	856	843	5000
MenuButton	mount	1623	1611	5000
MessageBar	mount	2367	2310	5000
Nav	mount	3088	3042	1000
OverflowSet	mount	1397	1399	5000
Panel	mount	2486	2486	1000
Persona	mount	1260	1255	1000
Pivot	mount	1537	1542	1000
PrimaryButton	mount	1476	1487	5000
Rating	mount	6923	6960	5000
SearchBox	mount	1513	1487	5000
Shimmer	mount	2938	2940	5000
Slider	mount	2103	2107	5000
SpinButton	mount	4260	4575	5000
Spinner	mount	836	822	5000
SplitButton	mount	2803	2809	5000
Stack	mount	858	867	5000
StackWithIntrinsicChildren	mount	2337	2315	5000
StackWithTextChildren	mount	5015	4975	5000
SwatchColorPicker	mount	9478	9458	5000
TagPicker	mount	2331	2339	5000
TeachingBubble	mount	78400	76778	5000
Text	mount	817	818	5000
TextField	mount	1574	1547	5000
ThemeProvider	mount	1429	1472	5000
ThemeProvider	virtual-rerender	1148	1148	5000
ThemeProvider	virtual-rerender-with-unmount	1990	2009	5000
Toggle	mount	1140	1131	5000
buttonNative	mount	542	534	5000

chore(scripts): remove unused logic from tsc,api-extractor used for p…

b6ca30c

…artial migration

msft-fluent-ui-bot assigned ling1726 Nov 15, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 15, 2022

Hotell changed the title ~~Hotell/build/api generation/remove gradual migration logic~~ chore(scripts): remove unused logic from tsc,api-extractor used for partial migration Nov 15, 2022

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 15, 2022

Hotell added Area: Build System Fluent UI react-components (v9) labels Nov 15, 2022

Hotell mentioned this pull request Nov 15, 2022

chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages #25679

Merged

1 task

chore(scripts): add back code from bad cherry pick conflict resolution

675d36c

Hotell force-pushed the hotell/build/api-generation/remove-gradual-migration-logic branch from aa685f9 to 675d36c Compare November 15, 2022 16:45

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 15, 2022

Hotell commented Nov 15, 2022

View reviewed changes

Hotell mentioned this pull request Nov 18, 2022

chore: remove unused logic used for gradual api-stripping migration #24127

Closed

2 tasks

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 28, 2022

Hotell mentioned this pull request Mar 6, 2023

chore(scripts-tasks): remove not needed api-extractor task logs #27094

Merged

Hotell closed this Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(scripts): remove unused logic from tsc,api-extractor used for partial migration#25678

chore(scripts): remove unused logic from tsc,api-extractor used for partial migration#25678
Hotell wants to merge 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/api-generation/remove-gradual-migration-logic

Hotell commented Nov 15, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 15, 2022 •

edited

Loading

Uh oh!

Hotell Nov 15, 2022

Uh oh!

fabricteam commented Nov 15, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Nov 15, 2022

Uh oh!

fabricteam commented Nov 15, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Nov 15, 2022

Uh oh!

fabricteam commented Nov 15, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hotell commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-requirements:

Current Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

Hotell Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Nov 15, 2022

Asset size changes

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

codesandbox-ci bot commented Nov 15, 2022

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Nov 15, 2022 •

edited

Loading

fabricteam commented Nov 15, 2022 •

edited

Loading

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)