fix(react-component): Remove unstable notice from stable components' readmes#25236
Merged
miroslavstastny merged 5 commits intomicrosoft:masterfrom Oct 24, 2022
Merged
Conversation
miroslavstastny
requested review from
a team,
behowell,
chpalac,
khmakoto,
ling1726,
smhigley,
sopranopillow and
spmonahan
as code owners
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2edff58:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: eff4a290cbb0ca8fd7023be1e46b2719564743e6 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1289 | 1292 | 5000 | |
| Button | mount | 952 | 930 | 5000 | |
| FluentProvider | mount | 1537 | 1544 | 5000 | |
| FluentProviderWithTheme | mount | 585 | 566 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 544 | 557 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 585 | 580 | 10 | |
| MakeStyles | mount | 1986 | 1945 | 50000 | |
| SpinButton | mount | 2402 | 2376 | 5000 |
Hotell
reviewed
Oct 14, 2022
Hotell
approved these changes
Oct 14, 2022
2 tasks
layershifter
approved these changes
Oct 14, 2022
sopranopillow
approved these changes
Oct 14, 2022
khmakoto
reviewed
Oct 14, 2022
Comment on lines
5
to
8
| ## STATUS: WIP 🚧 | ||
|
|
||
| These are not production-ready components and **should never be used in product**. This space is useful for testing new components whose APIs might change before final release. | ||
|
|
Member
There was a problem hiding this comment.
This one should not be removed, react-persona is still unstable.
khmakoto
approved these changes
Oct 17, 2022
TristanWatanabe
approved these changes
Oct 20, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…readmes (microsoft#25236) * fix(react-component): Remove unstable notice from stable components' readmes * Update project links in readmes * change files * revert react-persona, still unstable * revert react-persona, still unstable (change file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
react-componentspackage as well as other stable components contain unstable notice in readme:That message is not correct and confuses partners.
New Behavior
react-componentsand all stable packages.noneto avoid useless release.